Thread: pgsql: Fix some more bugs in contrib/xml2's xslt_process().

pgsql: Fix some more bugs in contrib/xml2's xslt_process().

From
Tom Lane
Date:
Fix some more bugs in contrib/xml2's xslt_process().

It failed to check for error return from xsltApplyStylesheet(), as reported
by Peter Gagarinov.  (So far as I can tell, libxslt provides no convenient
way to get a useful error message in failure cases.  There might be some
inconvenient way, but considering that this code is deprecated it's hard to
get enthusiastic about putting lots of work into it.  So I just made it say
"failed to apply stylesheet", in line with the existing error checks.)

While looking at the code I also noticed that the string returned by
xsltSaveResultToString was never freed, resulting in a session-lifespan
memory leak.

Back-patch to all supported versions.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/66fb03f53842e58d1025ad04888edc99f04793fa

Modified Files
--------------
contrib/xml2/xslt_proc.c |   14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)