Thread: pgsql: Add some enumeration commas, for consistency
Add some enumeration commas, for consistency Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/9cfd800aab9ee3c3b0b2b11ab41e129cc92dc15b Modified Files -------------- src/backend/access/gist/gistbuild.c | 2 +- src/backend/commands/async.c | 2 +- src/backend/commands/tablecmds.c | 2 +- src/backend/libpq/hba.c | 6 +++--- src/backend/utils/adt/float.c | 2 +- src/backend/utils/adt/numeric.c | 2 +- src/backend/utils/misc/guc.c | 4 ++-- src/bin/pg_basebackup/pg_basebackup.c | 2 +- src/bin/pg_dump/pg_dump.c | 2 +- src/bin/pg_dump/pg_restore.c | 2 +- src/test/regress/expected/numeric.out | 4 ++-- 11 files changed, 15 insertions(+), 15 deletions(-)
On 24 February 2012 09:05, Peter Eisentraut <peter_e@gmx.net> wrote: > Add some enumeration commas, for consistency Are you sure about this? Generally a serial comma isn't used before "and" unless splitting a list into larger sub-groups. e.g. The sun and the moon, flora and fauna, and flotsam and jetsam. -- Thom
On fre, 2012-02-24 at 09:16 +0000, Thom Brown wrote: > On 24 February 2012 09:05, Peter Eisentraut <peter_e@gmx.net> wrote: > > Add some enumeration commas, for consistency > > Are you sure about this? Generally a serial comma isn't used before > "and" It is in our source code. See also http://en.wikipedia.org/wiki/Serial_comma.
On 24 February 2012 09:28, Peter Eisentraut <peter_e@gmx.net> wrote: > On fre, 2012-02-24 at 09:16 +0000, Thom Brown wrote: >> On 24 February 2012 09:05, Peter Eisentraut <peter_e@gmx.net> wrote: >> > Add some enumeration commas, for consistency >> >> Are you sure about this? Generally a serial comma isn't used before >> "and" > > It is in our source code. See also > http://en.wikipedia.org/wiki/Serial_comma. Hmm... strikes me as a little odd, but okay. I've always followed this recommendation: http://www.ox.ac.uk/branding_toolkit/writing_and_style_guide/punctuation.html#athe_comma -- Thom