Thread: pgsql: Fix brain fade in previous pg_dump patch.

pgsql: Fix brain fade in previous pg_dump patch.

From
Tom Lane
Date:
Fix brain fade in previous pg_dump patch.

In pre-7.3 databases, pg_attribute.attislocal doesn't exist.  The easiest
way to make sure the new inheritance logic behaves sanely is to assume it's
TRUE, not FALSE.  This will result in printing child columns even when
they're not really needed.  We could work harder at trying to reconstruct a
value for attislocal, but there is little evidence that anyone still cares
about dumping from such old versions, so just do the minimum necessary to
have a valid dump.

I had this correct in the original draft of the patch, but for some
unaccountable reason decided it wasn't necessary to change the value.
Testing against an old server shows otherwise...

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/97dc3c8a147c01da38570e4be7b4979af918dca2

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)