Thread: pgsql: Code review for plpgsql fn_signature patch.
Code review for plpgsql fn_signature patch. Don't quote the output of format_procedure(); it's already quoted quite enough. Remove the fn_name field, which was now just dead weight. Fix remaining expected-output files. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/bef47331b6a1c0d081179a7fc9b82dd7e1862394 Modified Files -------------- src/pl/plpgsql/src/pl_comp.c | 2 - src/pl/plpgsql/src/pl_exec.c | 8 +- src/pl/plpgsql/src/pl_funcs.c | 4 +- src/pl/plpgsql/src/plpgsql.h | 1 - src/pl/plpython/expected/plpython_error.out | 4 +- src/pl/plpython/expected/plpython_error_0.out | 4 +- src/test/regress/expected/domain.out | 16 +++--- src/test/regress/expected/guc.out | 2 +- src/test/regress/expected/plancache.out | 4 +- src/test/regress/expected/plpgsql.out | 74 ++++++++++++------------ src/test/regress/expected/triggers.out | 74 ++++++++++++------------ 11 files changed, 95 insertions(+), 98 deletions(-)