Thread: pgsql: Add file-fdw documentation example.
Add file-fdw documentation example. Josh Berkus Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/1be6f9379287ecbbe6ab47636af7d41c7ae279ea Modified Files -------------- doc/src/sgml/file-fdw.sgml | 72 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 72 insertions(+), 0 deletions(-)
On 12/01/2011 09:34 AM, Bruce Momjian wrote: > Add file-fdw documentation example. > > Josh Berkus This example appears to be wrong: the extension creates the FDW for you, and doing it yourself again will result in an error. cheers andrew
On Thu, Dec 1, 2011 at 15:58, Andrew Dunstan <andrew@dunslane.net> wrote: > > > On 12/01/2011 09:34 AM, Bruce Momjian wrote: >> >> Add file-fdw documentation example. >> >> Josh Berkus > > > This example appears to be wrong: the extension creates the FDW for you, and > doing it yourself again will result in an error. Yeah, that was even pointed out in my review of the original patch.... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
On 12/1/11 7:01 AM, Magnus Hagander wrote: > On Thu, Dec 1, 2011 at 15:58, Andrew Dunstan <andrew@dunslane.net> wrote: >> >> >> On 12/01/2011 09:34 AM, Bruce Momjian wrote: >>> >>> Add file-fdw documentation example. >>> >>> Josh Berkus >> >> >> This example appears to be wrong: the extension creates the FDW for you, and >> doing it yourself again will result in an error. > > Yeah, that was even pointed out in my review of the original patch.... I'd swear I sent in a corrected patch. Lemme look for it. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com
On Thu, Dec 1, 2011 at 18:58, Josh Berkus <josh@agliodbs.com> wrote: > On 12/1/11 7:01 AM, Magnus Hagander wrote: >> On Thu, Dec 1, 2011 at 15:58, Andrew Dunstan <andrew@dunslane.net> wrote: >>> >>> >>> On 12/01/2011 09:34 AM, Bruce Momjian wrote: >>>> >>>> Add file-fdw documentation example. >>>> >>>> Josh Berkus >>> >>> >>> This example appears to be wrong: the extension creates the FDW for you, and >>> doing it yourself again will result in an error. >> >> Yeah, that was even pointed out in my review of the original patch.... > > I'd swear I sent in a corrected patch. Lemme look for it. Not waiting for this, I've just removed the incorrect instructions. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
Magnus Hagander wrote: > On Thu, Dec 1, 2011 at 18:58, Josh Berkus <josh@agliodbs.com> wrote: > > On 12/1/11 7:01 AM, Magnus Hagander wrote: > >> On Thu, Dec 1, 2011 at 15:58, Andrew Dunstan <andrew@dunslane.net> wrote: > >>> > >>> > >>> On 12/01/2011 09:34 AM, Bruce Momjian wrote: > >>>> > >>>> Add file-fdw documentation example. > >>>> > >>>> Josh Berkus > >>> > >>> > >>> This example appears to be wrong: the extension creates the FDW for you, and > >>> doing it yourself again will result in an error. > >> > >> Yeah, that was even pointed out in my review of the original patch.... > > > > I'd swear I sent in a corrected patch. ?Lemme look for it. > > Not waiting for this, I've just removed the incorrect instructions. Josh told me on Friday that he would apply a fix this weekend, but at this point he can restore the patch and fix it if he wants. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
Josh Berkus wrote: > > >> Not waiting for this, I've just removed the incorrect instructions. > > > > Josh told me on Friday that he would apply a fix this weekend, but at > > this point he can restore the patch and fix it if he wants. > > If magnus already fixed it, I don't see why I need to fix it again ... Oh, I thought Magnus removed the entire new section I added. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
>> Not waiting for this, I've just removed the incorrect instructions. > > Josh told me on Friday that he would apply a fix this weekend, but at > this point he can restore the patch and fix it if he wants. If magnus already fixed it, I don't see why I need to fix it again ... -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com