Thread: pgsql: pg_dump: Add gettext plural support to error message
pg_dump: Add gettext plural support to error message Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/9922fc5f9f02e9d1653d08b0e62cefa8560425be Modified Files -------------- src/bin/pg_dump/pg_dump.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
Peter Eisentraut <peter_e@gmx.net> writes:
> pg_dump: Add gettext plural support to error message
Er, what for? The case n=1 is explicitly excluded.
I'm not sure this message is even worth translating, since it should
be a can't-happen case, but making the translators do it twice is surely
unnecessary.
regards, tom lane
On tis, 2011-11-29 at 14:48 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > pg_dump: Add gettext plural support to error message
>
> Er, what for? The case n=1 is explicitly excluded.
Because other languages have more than one plural form. It's the same
reason why we have
if (ntups != 1)
{
write_msg(NULL, ngettext("query returned %d row instead of one: %s\n",
"query returned %d rows instead of one: %s\n",
ntups),
ntups, upgrade_query->data);
exit_nicely();
}
etc.