Thread: pgsql: Exit from base backups when shutdown is requested

pgsql: Exit from base backups when shutdown is requested

From
Magnus Hagander
Date:
Exit from base backups when shutdown is requested

When the exit waits until the whole backup completes, it may take
a very long time.

In passing, add back an error check in the main loop so we detect
clients that disconnect much earlier if the backup is large.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=688423d004f4092aed73c73a3281c281d476436d

Modified Files
--------------
src/backend/replication/basebackup.c |   14 +++++++++++++-
src/backend/replication/walsender.c  |   16 ++++++++--------
src/include/replication/walsender.h  |    2 ++
3 files changed, 23 insertions(+), 9 deletions(-)


Re: pgsql: Exit from base backups when shutdown is requested

From
Simon Riggs
Date:
On Fri, 2011-01-14 at 11:37 +0000, Magnus Hagander wrote:
> Exit from base backups when shutdown is requested
>
> When the exit waits until the whole backup completes, it may take
> a very long time.
>
> In passing, add back an error check in the main loop so we detect
> clients that disconnect much earlier if the backup is large.

Please make that the last commit in this area for next week.

I want to get a base from which to solidify the sync rep code, and
associated patches.

I'm not saying there will be a code clash, but there may be a clash of
detail or intention that will make life more difficult for testing.

Thanks,

--
 Simon Riggs           http://www.2ndQuadrant.com/books/
 PostgreSQL Development, 24x7 Support, Training and Services