Thread: pgsql: Reset the per-output-tuple exprcontext each time through the main

pgsql: Reset the per-output-tuple exprcontext each time through the main

From

tgl@postgresql.org (Tom Lane)

Date:

18 August 2010, 21:52:43

Log Message:
-----------
Reset the per-output-tuple exprcontext each time through the main loop in
ExecModifyTable().  This avoids memory leakage when trigger functions leave
junk behind in that context (as they more or less must).  Problem and solution
identified by Dean Rasheed.

I'm a bit concerned about the longevity of this solution --- once a plan can
have multiple ModifyTable nodes, we are very possibly going to have to do
something different.  But it should hold up for 9.0.

Tags:
----
REL9_0_STABLE

Modified Files:
--------------
    pgsql/src/backend/executor:
        nodeModifyTable.c (r1.7 -> r1.7.4.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeModifyTable.c?r1=1.7&r2=1.7.4.1)