Thread: pgsql: Only send cleanup_info messages if VACUUM removes any tuples.
pgsql: Only send cleanup_info messages if VACUUM removes any tuples.
From
sriggs@postgresql.org (Simon Riggs)
Date:
Log Message:
-----------
Only send cleanup_info messages if VACUUM removes any tuples.
There is no other purpose for this message type than to report
the latestRemovedXid of removed tuples, prior to index scans.
Removes overlooked path for sending invalid latestRemovedXid.
Fixes buildfarm failure on centaur.
Modified Files:
--------------
pgsql/src/backend/commands:
vacuumlazy.c (r1.133 -> r1.134)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/vacuumlazy.c?r1=1.133&r2=1.134)
sriggs@postgresql.org (Simon Riggs) writes:
> Removes overlooked path for sending invalid latestRemovedXid.
> Fixes buildfarm failure on centaur.
You're not there yet. There are multiple buildfarm machines showing
TRAP: FailedAssertion("!(((vacrelstats->latestRemovedXid) != ((TransactionId) 0)))", File: "vacuumlazy.c", Line: 690)
even after this patch was committed.
regards, tom lane
On Wed, 2010-04-21 at 21:03 -0400, Tom Lane wrote:
> sriggs@postgresql.org (Simon Riggs) writes:
> > Removes overlooked path for sending invalid latestRemovedXid.
> > Fixes buildfarm failure on centaur.
>
> You're not there yet. There are multiple buildfarm machines showing
>
> TRAP: FailedAssertion("!(((vacrelstats->latestRemovedXid) != ((TransactionId) 0)))", File: "vacuumlazy.c", Line: 690)
>
> even after this patch was committed.
Yes, I was aware of the failure because of further testing. Been on it
for the last hour. Dashed annoying.
--
Simon Riggs www.2ndQuadrant.com