Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgsql: Fix an oversight in join-removal optimization: we have to check

pgsql: Fix an oversight in join-removal optimization: we have to check

From
tgl@postgresql.org (Tom Lane)
Date:
Log Message:
-----------
Fix an oversight in join-removal optimization: we have to check not only for
plain Vars that are generated in the inner rel and used above the join, but
also for PlaceHolderVars.  Per report from Oleg K.

Modified Files:
--------------
    pgsql/src/backend/optimizer/path:
        joinpath.c (r1.130 -> r1.131)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/joinpath.c?r1=1.130&r2=1.131)
    pgsql/src/test/regress/expected:
        join.out (r1.43 -> r1.44)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.43&r2=1.44)
    pgsql/src/test/regress/sql:
        join.sql (r1.32 -> r1.33)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.32&r2=1.33)

Re: pgsql: Fix an oversight in join-removal optimization: we have to check

From
David Fetter
Date:
On Mon, Mar 22, 2010 at 01:57:16PM +0000, Tom Lane wrote:
> Log Message:
> -----------
> Fix an oversight in join-removal optimization: we have to check not only for
> plain Vars that are generated in the inner rel and used above the join, but
> also for PlaceHolderVars.  Per report from Oleg K.

That's short for Oleg Kolyhalin.  Can we get this into the release
notes?

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Re: pgsql: Fix an oversight in join-removal optimization: we have to check

From
Tom Lane
Date:
David Fetter <david@fetter.org> writes:
> On Mon, Mar 22, 2010 at 01:57:16PM +0000, Tom Lane wrote:
>> Log Message:
>> -----------
>> Fix an oversight in join-removal optimization: we have to check not only for
>> plain Vars that are generated in the inner rel and used above the join, but
>> also for PlaceHolderVars.  Per report from Oleg K.

> That's short for Oleg Kolyhalin.  Can we get this into the release
> notes?

We do not normally bother to record alpha bugs in the release notes.

            regards, tom lane