Thread: pgsql: Document why pgindent wants a fresh CVS checkout.

Log Message:
-----------
Document why pgindent wants a fresh CVS checkout.

Modified Files:
--------------
    pgsql/src/tools/pgindent:
        README (r1.34 -> r1.35)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.34&r2=1.35)

momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> Document why pgindent wants a fresh CVS checkout.

Why not just recommend "make maintainer-clean"?

I think that using a fresh checkout is a good idea to ensure that you
don't have any other changes in your tree (which would then get
committed silently and accidentally); but the reason given here is
pretty bogus.

BTW, shouldn't the sequence of steps be first download and then change
into that directory?

            regards, tom lane

Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Document why pgindent wants a fresh CVS checkout.
>
> Why not just recommend "make maintainer-clean"?
>
> I think that using a fresh checkout is a good idea to ensure that you
> don't have any other changes in your tree (which would then get
> committed silently and accidentally); but the reason given here is
> pretty bogus.

Ah, yea, I couldn't find that in psql/Makefile last night, but I see it
now.  I have updated the README.

> BTW, shouldn't the sequence of steps be first download and then change
> into that directory?

Yea, I removed the CVS download idea now that you showed me
maintainer-clean works.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +