Thread: pgsql: Add psql tab completion for DO blocks.

pgsql: Add psql tab completion for DO blocks.

From
itagaki@postgresql.org (Takahiro Itagaki)
Date:
Log Message:
-----------
Add psql tab completion for DO blocks.
Also adjust documentation of DO.

Patch from David Fetter and subsequent discussion.

Modified Files:
--------------
    pgsql/doc/src/sgml/ref:
        do.sgml (r1.3 -> r1.4)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/do.sgml?r1=1.3&r2=1.4)
    pgsql/src/bin/psql:
        tab-complete.c (r1.192 -> r1.193)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/tab-complete.c?r1=1.192&r2=1.193)

Re: pgsql: Add psql tab completion for DO blocks.

From
Tom Lane
Date:
itagaki@postgresql.org (Takahiro Itagaki) writes:
> Add psql tab completion for DO blocks.
> Also adjust documentation of DO.

This syntax synopsis is completely nuts:

DO { [ LANGUAGE <replaceable class="PARAMETER">lang_name</replaceable> ] | <replaceable
class="PARAMETER">code</replaceable>} ... 

It implies that an empty string is a valid substitute for the { ... }
construct, since I could take the first choice and then omit the
optional bracketed construct.

I think that it would be logically correct without the square brackets,
but as a matter of clarity I really doubt it's an improvement over the
original.

            regards, tom lane