Thread: pgsql: Also update ChangerLog file.
Log Message:
-----------
Also update ChangerLog file.
Modified Files:
--------------
pgsql/src/interfaces/ecpg:
ChangeLog (r1.403 -> r1.404)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ChangeLog?r1=1.403&r2=1.404)
On Fri, Jan 08, 2010 at 09:06:05AM +0000, Michael Meskes wrote: > Log Message: > ----------- > Also update ChangerLog file. This is *seriously* unhelpful. What in this file did you change, and what possessed you not to describe it in even the most general terms? Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
On Fri, Jan 08, 2010 at 10:08:38AM -0800, David Fetter wrote: > This is *seriously* unhelpful. What in this file did you change, and > what possessed you not to describe it in even the most general terms? What do you expect me to write when I just added a one line to the changelog saying that I applied Zoltan's patch? Yes, this should have been in the last commit but wasn't, but do you really expect me to add all the info into the commit yet again? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL
On Fri, Jan 8, 2010 at 4:57 PM, Michael Meskes <meskes@postgresql.org> wrote: > On Fri, Jan 08, 2010 at 10:08:38AM -0800, David Fetter wrote: >> This is *seriously* unhelpful. What in this file did you change, and >> what possessed you not to describe it in even the most general terms? > > What do you expect me to write when I just added a one line to the changelog > saying that I applied Zoltan's patch? Yes, this should have been in the last > commit but wasn't, but do you really expect me to add all the info into the > commit yet again? How about "Update ChangeLog for Zoltan's recent ECPG cleanup pach", or somesuch? ...Robert
On Sat, Jan 09, 2010 at 01:06:47PM -0500, Robert Haas wrote: > On Fri, Jan 8, 2010 at 4:57 PM, Michael Meskes <meskes@postgresql.org> wrote: > > On Fri, Jan 08, 2010 at 10:08:38AM -0800, David Fetter wrote: > >> This is *seriously* unhelpful. What in this file did you change, > >> and what possessed you not to describe it in even the most > >> general terms? > > > > What do you expect me to write when I just added a one line to the > > changelog saying that I applied Zoltan's patch? Yes, this should > > have been in the last commit but wasn't, but do you really expect > > me to add all the info into the commit yet again? > > How about "Update ChangeLog for Zoltan's recent ECPG cleanup pach", > or somesuch? I've phrased this as: - In pgsql/src/interfaces/ecpg/ChangeLog, add Zoltan Boszormenyi's recent ECPG cleanup patch. Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate