Thread: pgsql: Disallow comments on columns of relation types other than tables,
pgsql: Disallow comments on columns of relation types other than tables,
From
tgl@postgresql.org (Tom Lane)
Date:
Log Message:
-----------
Disallow comments on columns of relation types other than tables, views,
and composite types, which are the only relkinds for which pg_dump support
exists for dumping column comments. There is no obvious usefulness for
comments on columns of sequences or toast tables; and while comments on
index columns might have some value, it's not worth the risk of compatibility
problems due to possible changes in the algorithm for assigning names to
index columns. Per discussion.
In consequence, remove now-dead code for copying such comments in CREATE TABLE
LIKE.
Modified Files:
--------------
pgsql/src/backend/commands:
comment.c (r1.110 -> r1.111)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/comment.c?r1=1.110&r2=1.111)
pgsql/src/backend/parser:
parse_utilcmd.c (r2.33 -> r2.34)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.33&r2=2.34)
pgsql/src/test/regress/expected:
inherit.out (r1.29 -> r1.30)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out?r1=1.29&r2=1.30)
pgsql/src/test/regress/sql:
inherit.sql (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/inherit.sql?r1=1.14&r2=1.15)