Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgsql: Minor improvement: avoid assuming that GetLastError value cannot

pgsql: Minor improvement: avoid assuming that GetLastError value cannot

From
tgl@postgresql.org (Tom Lane)
Date:
Log Message:
-----------
Minor improvement: avoid assuming that GetLastError value cannot be
affected by CloseHandle() or Sleep().

Modified Files:
--------------
    pgsql/src/backend/port:
        win32_shmem.c (r1.9 -> r1.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/win32_shmem.c?r1=1.9&r2=1.10)

Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot

From
Magnus Hagander
Date:
Any reason you didn't backport this to the other versions that got the
SetLastError() fix?

//Magnus

Tom Lane wrote:
> Log Message:
> -----------
> Minor improvement: avoid assuming that GetLastError value cannot be
> affected by CloseHandle() or Sleep().
>
> Modified Files:
> --------------
>     pgsql/src/backend/port:
>         win32_shmem.c (r1.9 -> r1.10)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/win32_shmem.c?r1=1.9&r2=1.10)
>

Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot

From
Tom Lane
Date:
Magnus Hagander <magnus@hagander.net> writes:
> Any reason you didn't backport this to the other versions that got the
> SetLastError() fix?

AFAIK it's just a cosmetic improvement.  If you think there's a
significant risk then back-port away...

            regards, tom lane

Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot

From
Magnus Hagander
Date:
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Any reason you didn't backport this to the other versions that got the
>> SetLastError() fix?
>
> AFAIK it's just a cosmetic improvement.  If you think there's a
> significant risk then back-port away...

Not really, but it'd be easier if we need to backpatch more stuff later
if the source files are the same at least :-)

//Magnus