Thread: pgsql: Add missing descriptions for aggregates, functions and
pgsql: Add missing descriptions for aggregates, functions and
From
momjian@postgresql.org (Bruce Momjian)
Date:
Log Message:
-----------
Add missing descriptions for aggregates, functions and conversions.
Bernd Helmle
Modified Files:
--------------
pgsql/src/backend/utils/mb/conversion_procs:
Makefile (r1.19 -> r1.20)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mb/conversion_procs/Makefile?r1=1.19&r2=1.20)
pgsql/src/include/catalog:
catversion.h (r1.478 -> r1.479)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.478&r2=1.479)
pg_proc.h (r1.510 -> r1.511)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.510&r2=1.511)
momjian@postgresql.org (Bruce Momjian) writes: > Log Message: > ----------- > Add missing descriptions for aggregates, functions and conversions. > Bernd Helmle > Modified Files: > -------------- > pgsql/src/backend/utils/mb/conversion_procs: > Makefile (r1.19 -> r1.20) > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mb/conversion_procs/Makefile?r1=1.19&r2=1.20) Where's the Windows equivalent to that? regards, tom lane
--On Samstag, August 23, 2008 17:59:55 -0400 Tom Lane <tgl@sss.pgh.pa.us>
wrote:
> Where's the Windows equivalent to that?
Uhm, good question ;) Do you have a hint, since i never hacked our windows
built infrastructure?
--
Thanks
Bernd
Bernd Helmle wrote: > --On Samstag, August 23, 2008 17:59:55 -0400 Tom Lane > <tgl@sss.pgh.pa.us> wrote: > >> Where's the Windows equivalent to that? > > Uhm, good question ;) Do you have a hint, since i never hacked our > windows built infrastructure? It's the perl-scripts in src/tools/msvc. You're looking for GenerateConversionScript in Install.pm. //Magnus
Bernd Helmle wrote: > --On Samstag, August 23, 2008 17:59:55 -0400 Tom Lane <tgl@sss.pgh.pa.us> > wrote: > >> Where's the Windows equivalent to that? > > Uhm, good question ;) Do you have a hint, since i never hacked our > windows built infrastructure? See src/tools/msvc/Install.pm It would be good to add a comment on both places that the other one needs to be updated in conjunction. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.
--On Samstag, August 23, 2008 17:59:55 -0400 Tom Lane <tgl@sss.pgh.pa.us> wrote: > Where's the Windows equivalent to that? Uhm, good question ;) Do you have a hint, since i never hacked our windows built infrastructure? -- Bernd
Bernd Helmle wrote: > --On Samstag, August 23, 2008 17:59:55 -0400 Tom Lane <tgl@sss.pgh.pa.us> > wrote: > > > Where's the Windows equivalent to that? > > Uhm, good question ;) Do you have a hint, since i never hacked our windows > built infrastructure? Well, seeing as no one else has done this --- done with the attached applied patch. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: Install.pm =================================================================== RCS file: /cvsroot/pgsql/src/tools/msvc/Install.pm,v retrieving revision 1.29 retrieving revision 1.30 diff -c -c -r1.29 -r1.30 *** Install.pm 28 Feb 2008 12:17:59 -0000 1.29 --- Install.pm 5 Sep 2008 16:54:39 -0000 1.30 *************** *** 216,223 **** --- 216,226 ---- $sql .= "-- $se --> $de\n"; $sql .= "CREATE OR REPLACE FUNCTION $func (INTEGER, INTEGER, CSTRING, INTERNAL, INTEGER) RETURNS VOID AS '\$libdir/$obj', '$func'LANGUAGE C STRICT;\n"; + $sql .= + "COMMENT ON FUNCTION $func(INTEGER, INTEGER, CSTRING, INTERNAL, INTEGER) IS 'internal conversion function for $se to $de';\n"; $sql .= "DROP CONVERSION pg_catalog.$name;\n"; $sql .= "CREATE DEFAULT CONVERSION pg_catalog.$name FOR '$se' TO '$de' FROM $func;\n"; + $sql .= "COMMENT ON CONVERSION pg_catalog.$name IS 'conversion for $se to $de';\n"; } open($F,">$target/share/conversion_create.sql") || die "Could not write to conversion_create.sql\n";