Thread: pgsql: Publish more openly the fact that autovacuum is working for
pgsql: Publish more openly the fact that autovacuum is working for
From
alvherre@postgresql.org (Alvaro Herrera)
Date:
Log Message:
-----------
Publish more openly the fact that autovacuum is working for wraparound
protection.
Simon Riggs
Modified Files:
--------------
pgsql/src/backend/postmaster:
autovacuum.c (r1.81 -> r1.82)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/autovacuum.c?r1=1.81&r2=1.82)
alvherre@postgresql.org (Alvaro Herrera) writes:
> Publish more openly the fact that autovacuum is working for wraparound
> protection.
Now that I look more closely, there are two things I don't like about
this patch:
* it fails to ratchet up MAX_AUTOVAC_ACTIV_LEN to allow for the
additional text
* it produces something like
autovacuum: VACUUM (to prevent wraparound) foo.bar
I had thought we were generating
autovacuum: VACUUM foo.bar (to prevent wraparound)
which seems both easier to read and less likely to break any
existing code that might be trying to interpret pg_stat_activity
entries.
regards, tom lane
On Mon, 2008-07-21 at 11:45 -0400, Tom Lane wrote: > alvherre@postgresql.org (Alvaro Herrera) writes: > > Publish more openly the fact that autovacuum is working for wraparound > > protection. > > Now that I look more closely, there are two things I don't like about > this patch: > > * it fails to ratchet up MAX_AUTOVAC_ACTIV_LEN to allow for the > additional text > > * it produces something like > > autovacuum: VACUUM (to prevent wraparound) foo.bar > > I had thought we were generating > > autovacuum: VACUUM foo.bar (to prevent wraparound) > > which seems both easier to read and less likely to break any > existing code that might be trying to interpret pg_stat_activity > entries. Ratcheted. Will do 8.3 change once approved. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support
Attachment
On Tue, 2008-07-22 at 14:19 +0100, Simon Riggs wrote: > Will do 8.3 change once approved. Here it is. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support
Attachment
Simon Riggs wrote: > > On Tue, 2008-07-22 at 14:19 +0100, Simon Riggs wrote: > > > Will do 8.3 change once approved. > > Here it is. Applied, thanks. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support