Thread: pgsql: Add a field to guc enums to allow hiding of values from display
pgsql: Add a field to guc enums to allow hiding of values from display
From
mha@postgresql.org (Magnus Hagander)
Date:
Log Message:
-----------
Add a field to guc enums to allow hiding of values from display while
still accepting them as input, used to allow alternate syntax for the
same setting.
Alex Hunsaker
Modified Files:
--------------
pgsql/src/backend/utils/misc:
guc.c (r1.455 -> r1.456)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.455&r2=1.456)
pgsql/src/include/utils:
guc.h (r1.95 -> r1.96)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h?r1=1.95&r2=1.96)
mha@postgresql.org (Magnus Hagander) writes:
> Add a field to guc enums to allow hiding of values from display while
> still accepting them as input, used to allow alternate syntax for the
> same setting.
Aren't there some config_enum_entrys elsewhere (like xlog.c)?
I think they'd default to false, but still it'd be better practice
to fill them in.
regards, tom lane
Re: pgsql: Add a field to guc enums to allow hiding of values from display
From
Magnus Hagander
Date:
Tom Lane wrote: > mha@postgresql.org (Magnus Hagander) writes: > > Add a field to guc enums to allow hiding of values from display > > while still accepting them as input, used to allow alternate syntax > > for the same setting. > > Aren't there some config_enum_entrys elsewhere (like xlog.c)? > I think they'd default to false, but still it'd be better practice > to fill them in. Hmm. I thought I was going to get warnings if I missed any, but it seems not. Will fix. //Magnus
Re: pgsql: Add a field to guc enums to allow hiding of values from display
From
"Alex Hunsaker"
Date:
On Wed, May 28, 2008 at 8:33 AM, Magnus Hagander <magnus@hagander.net> wrote: > Tom Lane wrote: >> mha@postgresql.org (Magnus Hagander) writes: >> > Add a field to guc enums to allow hiding of values from display >> > while still accepting them as input, used to allow alternate syntax >> > for the same setting. >> >> Aren't there some config_enum_entrys elsewhere (like xlog.c)? >> I think they'd default to false, but still it'd be better practice >> to fill them in. > > Hmm. I thought I was going to get warnings if I missed any, but it > seems not. Will fix. > Oops I could have sworn i grepped the source for them... Sorry!