Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgsql: Allow an autovacuum worker to be interrupted automatically when

pgsql: Allow an autovacuum worker to be interrupted automatically when

From
alvherre@postgresql.org (Alvaro Herrera)
Date:
Log Message:
-----------
Allow an autovacuum worker to be interrupted automatically when it is found
to be locking another process (except when it's working to prevent Xid
wraparound problems).

Modified Files:
--------------
    pgsql/src/backend/postmaster:
        autovacuum.c (r1.65 -> r1.66)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/autovacuum.c?r1=1.65&r2=1.66)
    pgsql/src/backend/storage/lmgr:
        README (r1.21 -> r1.22)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/README?r1=1.21&r2=1.22)
        deadlock.c (r1.48 -> r1.49)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/deadlock.c?r1=1.48&r2=1.49)
        proc.c (r1.195 -> r1.196)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/proc.c?r1=1.195&r2=1.196)
    pgsql/src/include/storage:
        lock.h (r1.107 -> r1.108)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/storage/lock.h?r1=1.107&r2=1.108)

Re: pgsql: Allow an autovacuum worker to be interrupted automatically when

From
Simon Riggs
Date:
On Fri, 2007-10-26 at 20:45 +0000, Alvaro Herrera wrote:
> Log Message:
> -----------
> Allow an autovacuum worker to be interrupted automatically when it is found
> to be locking another process (except when it's working to prevent Xid
> wraparound problems).

Hi Alvaro,

Not sure if this was my patch you committed, or did it need a re-write?

Thanks, whichever.

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com

Re: pgsql: Allow an autovacuum worker to be interrupted automatically when

From
"Alvaro Herrera"
Date:
Hi Simon,

Sorry I forgot to mention your name in the commit message :-(  This
weekend I'm moving to a new flat so I was distracted.  Thanks for the
patch, I didn't change it much.

This is also the only excuse I have for being unavailable to commit other
fixes; I apologize for neglecting letting you all know.

I'll commit a separate patch to credit you for the patch (unless somebody
beats me to it -- feel free, as I'll have limited Internet connectivity
for a few days yet).

Thanks,

> On Fri, 2007-10-26 at 20:45 +0000, Alvaro Herrera wrote:
>> Log Message:
>> -----------
>> Allow an autovacuum worker to be interrupted automatically when it is
>> found
>> to be locking another process (except when it's working to prevent Xid
>> wraparound problems).
>
> Hi Alvaro,
>
> Not sure if this was my patch you committed, or did it need a re-write?
>
> Thanks, whichever.


--
Alvaro Herrera, on a broken stupid webmail

Re: pgsql: Allow an autovacuum worker to be interrupted automatically when

From
Simon Riggs
Date:
On Sat, 2007-10-27 at 22:13 -0300, Alvaro Herrera wrote:

> Sorry I forgot to mention your name in the commit message :-(  This
> weekend I'm moving to a new flat so I was distracted.  Thanks for the
> patch, I didn't change it much.

> I'll commit a separate patch to credit you for the patch

Many thanks.

Mentioning the author's name is important, whoever the author is, unless
it was the committer that performed the work. Some people get paid to
submit patches in various ways, others request time from their
employers, some people just for fun. The author credit proves that time
was well spent and will help ensure we get more patches from that
source, so its good for everybody that this happens for all patches.

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com