Thread: pgsql: Some small tuptoaster improvements from Greg Stark.

Log Message:
-----------
Some small tuptoaster improvements from Greg Stark.  Avoid unnecessary
decompression of an already-compressed external value when we have to copy
it; save a few cycles when a value is too short for compression; and
annotate various lines that are currently unreachable.

Modified Files:
--------------
    pgsql/src/backend/access/heap:
        tuptoaster.c (r1.74 -> r1.75)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/heap/tuptoaster.c?r1=1.74&r2=1.75)

"Tom Lane" <tgl@postgresql.org> writes:

> Log Message:
> -----------
> Some small tuptoaster improvements from Greg Stark.  Avoid unnecessary
> decompression of an already-compressed external value when we have to copy
> it; save a few cycles when a value is too short for compression; and
> annotate various lines that are currently unreachable.

There were some further changes you suggested involving rethinking the way the
compression strategy works. Should I put that on my todo list for early in 8.4?

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

Gregory Stark <stark@enterprisedb.com> writes:
> There were some further changes you suggested involving rethinking the
> way the compression strategy works. Should I put that on my todo list
> for early in 8.4?

Sure, if you feel like working on it.  (I'd hoped to get to that myself
for 8.3, but we are now well past the point where any new work should
be considered...)

            regards, tom lane