Thread: pgsql: Check return code from strxfrm on Windows since it has a

Log Message:
-----------
Check return code from strxfrm on Windows since it has a
non-standard way of indicating errors, so we don't try to
allocate INT_MAX bytes to store a result in.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        selfuncs.c (r1.233 -> r1.234)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/selfuncs.c.diff?r1=1.233&r2=1.234)

FYI, you forgot the author's in the commit message, ITAGAKI Takahiro.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Log Message:
> -----------
> Check return code from strxfrm on Windows since it has a
> non-standard way of indicating errors, so we don't try to
> allocate INT_MAX bytes to store a result in.
>
> Modified Files:
> --------------
>     pgsql/src/backend/utils/adt:
>         selfuncs.c (r1.233 -> r1.234)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/selfuncs.c.diff?r1=1.233&r2=1.234)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

This is actually a different patch. I'm still waiting for confirmation
on if it's enough or if we need both this patch and the original, or if
this one is enough to solve his problem.

Still, I did forget the report-and-research attribution. My apologies.

//Magnus


Bruce Momjian wrote:
> FYI, you forgot the author's in the commit message, ITAGAKI Takahiro.
>
> ---------------------------------------------------------------------------
>
> Magnus Hagander wrote:
>> Log Message:
>> -----------
>> Check return code from strxfrm on Windows since it has a
>> non-standard way of indicating errors, so we don't try to
>> allocate INT_MAX bytes to store a result in.
>>
>> Modified Files:
>> --------------
>>     pgsql/src/backend/utils/adt:
>>         selfuncs.c (r1.233 -> r1.234)
>>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/selfuncs.c.diff?r1=1.233&r2=1.234)
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 9: In versions below 8.0, the planner will ignore your desire to
>>        choose an index scan if your joining column's datatypes do not
>>        match
>