Thread: pgsql: Move "#define inline __inline" from port/win32.h to c.h because
pgsql: Move "#define inline __inline" from port/win32.h to c.h because
From
momjian@postgresql.org (Bruce Momjian)
Date:
Log Message: ----------- Move "#define inline __inline" from port/win32.h to c.h because Win32 interface builds like libpq need it. Backpatch addition to 8.1.X. Modified Files: -------------- pgsql/src/include: c.h (r1.209 -> r1.210) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h.diff?r1=1.209&r2=1.210) pgsql/src/include/port: win32.h (r1.56 -> r1.57) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/port/win32.h.diff?r1=1.56&r2=1.57)
momjian@postgresql.org (Bruce Momjian) writes: > Move "#define inline __inline" from port/win32.h to c.h because Win32 > interface builds like libpq need it. Huh? port/win32.h is #included by c.h (as pg_config_os.h), no? I don't see why it's necessary to clutter c.h with this platform-specific hack, when we have a perfectly fine mechanism for not doing that. regards, tom lane
Tom Lane wrote: > momjian@postgresql.org (Bruce Momjian) writes: > > Move "#define inline __inline" from port/win32.h to c.h because Win32 > > interface builds like libpq need it. > > Huh? port/win32.h is #included by c.h (as pg_config_os.h), no? > I don't see why it's necessary to clutter c.h with this > platform-specific hack, when we have a perfectly fine mechanism > for not doing that. Right. I was wrong and the problem was that the inline define was missing in the win32.h. That has been fixed in a later commit. -- Bruce Momjian bruce@momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +