Thread: pgsql: As a stopgap to get the Windows buildfarm members running again,

pgsql: As a stopgap to get the Windows buildfarm members running again,

From
tgl@postgresql.org (Tom Lane)
Date:
Log Message:
-----------
As a stopgap to get the Windows buildfarm members running again, hot-wire
the check on diff's exit status to check for literally 0 or 1.  Someone
should look into why WIFEXITED/WEXITSTATUS don't work for this, but I've
spent more than enough time on it already.

Modified Files:
--------------
    pgsql/src/test/regress:
        pg_regress.c (r1.9 -> r1.10)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c.diff?r1=1.9&r2=1.10)

Re: pgsql: As a stopgap to get the Windows buildfarm members running again,

From
"Hiroshi Saito"
Date:
Tom-san.
Ahhhh...Sorry.
It looked for the optimal result.

> =======================
> All 100 tests passed.
> =======================
>
>
> However, A result tells a lie. So, pursuit continues tracking.
>
> $ diff -w "./expected/char.out" "./results/char.out"
> 66d65

diff -w "./expected/char_1.out" "./results/char.out"

Then, It seems that it is now in good order.
Sorry, I was distracted for a while............
Thanks.

Regards,
Hiroshi Saito






Re: pgsql: As a stopgap to get the Windows buildfarm members running again,

From
"Hiroshi Saito"
Date:
Hi Tom-san.

From: "Tom Lane" <tgl@postgresql.org>


> Log Message:
> -----------
> As a stopgap to get the Windows buildfarm members running again, hot-wire
> the check on diff's exit status to check for literally 0 or 1.  Someone
> should look into why WIFEXITED/WEXITSTATUS don't work for this, but I've
> spent more than enough time on it already.
>
> Modified Files:
> --------------
>    pgsql/src/test/regress:
>        pg_regress.c (r1.9 -> r1.10)
>
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c.diff?r1=1.9&r2=1.10)
>

Hm, Surely, although it is forcing, it removes one problem.

schedule=./parallel_schedule --multibyte=SQL_ASCII --load-language=plpgsql
============== creating temporary installation        ==============
============== initializing database system           ==============
============== starting postmaster                    ==============
running on port 55432 with pid 1964
============== creating database "regression"         ==============
CREATE DATABASE
ALTER DATABASE
============== installing plpgsql                     ==============
CREATE LANGUAGE
============== running regression test queries        ==============
parallel group (13 tests):  text oid varchar char name float4 int2 boolean int8 int4 float8 bit
numeric
     boolean              ... ok
     char                 ... ok
     name                 ... ok
     varchar              ... ok
     text                 ... ok
     int2                 ... ok
(snip).......
     truncate             ... ok
     alter_table          ... ok
     sequence             ... ok
     polymorphism         ... ok
     rowtypes             ... ok
test stats                ... ok
test tablespace           ... ok
============== shutting down postmaster               ==============
server stopped

=======================
 All 100 tests passed.
=======================


However, A result tells a lie. So, pursuit continues tracking.

$ diff -w "./expected/char.out" "./results/char.out"
66d65
<       | A
71c70
< (5 rows)
---
> (4 rows)
79d77
<      | A
84c82
< (6 rows)
---
> (5 rows)
90a89
>      | A
92c91
< (1 row)
---
> (2 rows)
99a99
>      | A
101c101
< (2 rows)
---
> (3 rows)


Ugaa...
 this is strange....

Regards,
Hiroshi Saito
Regards,
Hiroshi Saito