Thread: pgsql: Do a pass of code review for the ALTER TABLE ADD INHERITS patch.
pgsql: Do a pass of code review for the ALTER TABLE ADD INHERITS patch.
From
neilc@postgresql.org (Neil Conway)
Date:
Log Message:
-----------
Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
the read lock we hold on the table's parent relation until commit.
Update equalfuncs.c for the new field in AlterTableCmd. Various
improvements to comments, variable names, and error reporting.
There is room for further improvement here, but this is at least
a step in the right direction.
Modified Files:
--------------
pgsql/src/backend/commands:
tablecmds.c (r1.190 -> r1.191)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c.diff?r1=1.190&r2=1.191)
pgsql/src/backend/nodes:
copyfuncs.c (r1.340 -> r1.341)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c.diff?r1=1.340&r2=1.341)
equalfuncs.c (r1.274 -> r1.275)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c.diff?r1=1.274&r2=1.275)
pgsql/src/test/regress/expected:
alter_table.out (r1.95 -> r1.96)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out.diff?r1=1.95&r2=1.96)