Thread: pgsql: Remove ill-considered suppression of gcc warnings in plperl, and

pgsql: Remove ill-considered suppression of gcc warnings in plperl, and

From
tgl@svr1.postgresql.org (Tom Lane)
Date:
Log Message:
-----------
Remove ill-considered suppression of gcc warnings in plperl, and fix
some of the bugs exposed thereby.  The remaining 'might be used uninitialized'
warnings look like live bugs, but I am not familiar enough with Perl/C hacking
to tell how to fix them.

Modified Files:
--------------
    pgsql/src/pl/plperl:
        GNUmakefile (r1.16 -> r1.17)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/GNUmakefile.diff?r1=1.16&r2=1.17)
        plperl.c (r1.56 -> r1.57)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c.diff?r1=1.56&r2=1.57)

Re: pgsql: Remove ill-considered suppression of gcc warnings in plperl, and

From
Michael Fuhr
Date:
On Wed, Nov 17, 2004 at 09:23:37PM +0000, Tom Lane wrote:

> Remove ill-considered suppression of gcc warnings in plperl, and fix
> some of the bugs exposed thereby.

These changes may not have targeted the problem mentioned in the
"plperl crashes backend" thread in pgsql-bugs, but I'll report that
they didn't fix it.  After rebuilding I can still reproduce the
crash.

http://archives.postgresql.org/pgsql-bugs/2004-11/msg00216.php

--
Michael Fuhr
http://www.fuhr.org/~mfuhr/