Thread: pgsql-server/src/backend/utils/adt network.c

pgsql-server/src/backend/utils/adt network.c

From
tgl@svr1.postgresql.org (Tom Lane)
Date:
CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    tgl@svr1.postgresql.org    03/12/01 14:50:19

Modified files:
    src/backend/utils/adt: network.c

Log message:
    netmask() and hostmask() functions should return maximum-length masklen,
    per gripe from Joe Sunday.


Re: pgsql-server/src/backend/utils/adt network.c

From
Neil Conway
Date:
tgl@svr1.postgresql.org (Tom Lane) writes:
>     netmask() and hostmask() functions should return maximum-length masklen,
>     per gripe from Joe Sunday.

Should we add some regression tests for this behavior?

-Neil


Re: pgsql-server/src/backend/utils/adt network.c

From
Tom Lane
Date:
Neil Conway <neilc@samurai.com> writes:
> tgl@svr1.postgresql.org (Tom Lane) writes:
>> netmask() and hostmask() functions should return maximum-length masklen,
>> per gripe from Joe Sunday.

> Should we add some regression tests for this behavior?

Don't much care --- it doesn't seem like the kind of thing that's likely
to break again, unless someone deliberately changes the behavior (which
is what happened here AFAICT; a regression test would hardly prevent it).

            regards, tom lane