Thread: pgsql-server/src/port Makefile

CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    petere@svr1.postgresql.org    03/10/24 17:31:43

Modified files:
    src/port       : Makefile

Log message:
    Use AROPT, not hard-coded flags.

petere@svr1.postgresql.org (Peter Eisentraut - PostgreSQL) writes:
> Modified files:
>     src/port       : Makefile
> Log message:
>     Use AROPT, not hard-coded flags.

This patch broke the Darwin port, and invalidated whatever port reports
we now have for platforms where AROPT isn't "crs" (which includes all
the BSDen as well as a couple other platforms --- can any BSDers report
whether CVS tip still builds for them?).  I suggest more prudence
about making portability-related fixes when we are hard upon a release.
Was there any reported bug that this actually fixed?

            regards, tom lane

Tom Lane writes:

> This patch broke the Darwin port, and invalidated whatever port reports
> we now have for platforms where AROPT isn't "crs" (which includes all
> the BSDen as well as a couple other platforms --- can any BSDers report
> whether CVS tip still builds for them?).  I suggest more prudence
> about making portability-related fixes when we are hard upon a release.
> Was there any reported bug that this actually fixed?

The OpenBSD port was broken, because the ar program did not support the
flags that used to be there.  Elsewhere, we use AROPT to build a static
library as well.

--
Peter Eisentraut   peter_e@gmx.net