Thread: pgsql-server/ rc/backend/parser/Tag: rc/backen ...

CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    tgl@postgresql.org    03/01/31 15:58:28

Modified files:
    src/backend/parser: Tag: REL7_3_STABLE Makefile
    contrib/cube   : Tag: REL7_3_STABLE Makefile
    contrib/seg    : Tag: REL7_3_STABLE Makefile

Log message:
    Tweak bison build rules so that we get the same error messages from
    bison 1.875 and later as we did from earlier bison releases.  Eventually
    we will probably want to adopt the newer message spelling ... but not yet.
    Per recent discussion on pgpatches.
    Note: I didn't change the build rules for bootstrap, ecpg, or plpgsql
    grammars, since these do not affect regression test results.

On Fri, 2003-01-31 at 15:58, Tom Lane wrote:
>     Note: I didn't change the build rules for bootstrap, ecpg, or plpgsql
>     grammars, since these do not affect regression test results.

Wasn't the intent of papering-over the bison change to ensure that
client applications that look at error messages aren't gratuitously
broken?

Cheers,

Neil
--
Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC

Neil Conway <neilc@samurai.com> writes:
> On Fri, 2003-01-31 at 15:58, Tom Lane wrote:
>> Note: I didn't change the build rules for bootstrap, ecpg, or plpgsql
>> grammars, since these do not affect regression test results.

> Wasn't the intent of papering-over the bison change to ensure that
> client applications that look at error messages aren't gratuitously
> broken?

Yes.  Client apps aren't going to be seeing errors out of bootstrap.
I doubt anyone is going to be expecting their apps to analyze syntax
errors in plpgsql functions, either.  As for ecpg, Michael would be
the last word on it, and he can change the ecpg makefile if he likes ---
but ecpg is a preprocessor, not an interactive frontend.  I don't see
that anyone's going to be passing ecpg parse errors to programs,
either.

            regards, tom lane