Thread: pgsql-server/src/port fseeko.c

CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    momjian@postgresql.org    02/10/23 17:16:17

Modified files:
    src/port       : fseeko.c

Log message:
    Make BSD/OS fseeko thread-safe.

Bruce Momjian - CVS writes:

> Log message:
>     Make BSD/OS fseeko thread-safe.

I don't think that standard fseeko is thread safe.  The whole FILE* based
API is suspect.

--
Peter Eisentraut   peter_e@gmx.net

Peter Eisentraut wrote:
> Bruce Momjian - CVS writes:
>
> > Log message:
> >     Make BSD/OS fseeko thread-safe.
>
> I don't think that standard fseeko is thread safe.  The whole FILE* based
> API is suspect.

I think the issue is that when you do a SEEK_CUR/SEEK_END, you have to
take a snapshot of where the current pointer is or the current file
size, so you should lock out other threads while you do those
operations.  If you didn't, there could be random unreliability in the
function.


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073