Thread: pgsql-server/src/pl plpython/feature.expected ...

pgsql-server/src/pl plpython/feature.expected ...

From
momjian@postgresql.org (Bruce Momjian - CVS)
Date:
CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    momjian@postgresql.org    02/10/14 00:20:52

Modified files:
    src/pl/plpython: feature.expected plpython.c plpython_schema.sql
    src/pl/tcl     : pltcl.c

Log message:
    I have attached two patches as per:

    1) pltcl:
    Add SPI_freetuptable() calls to avoid memory leaks (Me + Neil Conway)
    Change sprintf()s to snprintf()s (Neil Conway)
    Remove header files included elsewhere (Neil Conway)

    2)plpython:
    Add SPI_freetuptable() calls to avoid memory leaks
    Cosemtic change to remove a compiler warning

    Notes:

    I have tested pltcl.c for
    a) the original leak problem reported for the repeated call of spi_exec
    in a TCL fragment
    and
    b) the subsequent report resulting from the use of spi_exec -array
    in a TCL
    fragment.

    The plpython.c patch is exactly the same as that applied to make
    revision 1.23,
    the plpython_schema.sql and feature.expected sections of the patch are
    also the
    same as last submited, applied and subsequently reversed out. It remains
    untested by me (other than via make check). However, this should be safe
    provided PyString_FromString() _copies_ the given string to make a
    PyObject.

    Nigel J. Andrews