Thread: pgsql/src/backend catalog/heap.c utils/adt/tid.c

CVSROOT:    /cvsroot
Module name:    pgsql
Changes by:    inoue@postgresql.org    02/05/22 03:46:58

Modified files:
    src/backend/catalog: heap.c
    src/backend/utils/adt: tid.c

Log message:
    Allow
    CREATE VIEW as SELECT CTID, ....
    SELECT currtid( a view, ..).

On Wed, 22 May 2002 03:46:58 -0400 (EDT)
"Hiroshi Inoue" <inoue@postgresql.org> wrote:
> Log message:
>     Allow
>     CREATE VIEW as SELECT CTID, ....
>     SELECT currtid( a view, ..).

Hiroshi,

Can you elaborate on exactly what your modification allows?

Also, would it be appropriate to add regression tests for this?

Cheers,

Neil

--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC

Neil Conway wrote:
>
> On Wed, 22 May 2002 03:46:58 -0400 (EDT)
> "Hiroshi Inoue" <inoue@postgresql.org> wrote:
> > Log message:
> >       Allow
> >       CREATE VIEW as SELECT CTID, ....
> >       SELECT currtid( a view, ..).
>
> Hiroshi,
>
> Can you elaborate on exactly what your modification allows?

Before the change, views have meaningless system columns.
After the change, views have no system columns basically
and users could add columns with system column name.

My main intention is to allow scan by TIDs on views.
Scan by TIDs is the fastest random access to PG tables
and I'm using the scan to implement updatable cursors
in ODBC driver. I'd not like to discourage users to
use views.

> Also, would it be appropriate to add regression tests for this?

Not sure.
AFAIK few people are interested in system columns
other than OID.

regards,
Hiroshi Inoue