Thread: pgsql/src/interfaces/libpq fe-connect.c fe-exe ...

CVSROOT:    /home/projects/pgsql/cvsroot
Module name:    pgsql
Changes by:    momjian@hub.org    01/07/20 13:45:06

Modified files:
    src/interfaces/libpq: fe-connect.c fe-exec.c fe-misc.c win32.h

Log message:
    i've spotted a following problem using DBD::Pg under win32. winsock
    functions do not set errno, so some normal conditions are treated as
    fatal errors. e.g. fetching large tuples fails, as at some point recv()
    returns EWOULDBLOCK. here's a patch, which replaces errno with
    WSAGetLastError(). i've tried to to affect non-win32 code.

    Dmitry Yurtaev

Bruce Momjian - CVS <momjian@hub.org> writes:
> Log message:
>     i've spotted a following problem using DBD::Pg under win32. winsock
>     functions do not set errno, so some normal conditions are treated as
>     fatal errors. e.g. fetching large tuples fails, as at some point recv()
>     returns EWOULDBLOCK. here's a patch, which replaces errno with
>     WSAGetLastError(). i've tried to to affect non-win32 code.

I thought this was awaiting a merged patch from both submitters?

Certainly I haven't reviewed it, since I thought that we were not
going to apply it until that happened.

            regards, tom lane

> Bruce Momjian - CVS <momjian@hub.org> writes:
> > Log message:
> >     i've spotted a following problem using DBD::Pg under win32. winsock
> >     functions do not set errno, so some normal conditions are treated as
> >     fatal errors. e.g. fetching large tuples fails, as at some point recv()
> >     returns EWOULDBLOCK. here's a patch, which replaces errno with
> >     WSAGetLastError(). i've tried to to affect non-win32 code.
>
> I thought this was awaiting a merged patch from both submitters?
>
> Certainly I haven't reviewed it, since I thought that we were not
> going to apply it until that happened.

The other maintainer said this patch was better.  He wants a few lines
of his patch added as well and he will send that over soon.  You want to
see the applied patch or have it backed out?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> I thought this was awaiting a merged patch from both submitters?

> The other maintainer said this patch was better.

Oh, I guess I missed that message.

> He wants a few lines
> of his patch added as well and he will send that over soon.  You want to
> see the applied patch or have it backed out?

No, I'll just look at the combined diff once both patches are in.

            regards, tom lane

> Bruce Momjian - CVS <momjian@hub.org> writes:
> > Log message:
> >     i've spotted a following problem using DBD::Pg under win32. winsock
> >     functions do not set errno, so some normal conditions are treated as
> >     fatal errors. e.g. fetching large tuples fails, as at some point recv()
> >     returns EWOULDBLOCK. here's a patch, which replaces errno with
> >     WSAGetLastError(). i've tried to to affect non-win32 code.
>
> I thought this was awaiting a merged patch from both submitters?
>
> Certainly I haven't reviewed it, since I thought that we were not
> going to apply it until that happened.

I have applied both fixes.  Win32 users can start testing.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026