Thread: Current CVS in a bad state?

Current CVS in a bad state?

From
Peter T Mount
Date:
Hmmm, I've just checked out the current cvs, and the directory:

  src/interfaces/jdbc/postgresql

has reappeared. This was deleted quite a few months ago and is obsolete. Any
ideas on how this got back in?

Was there a restore of some kind made? I'm looking into a bug report which I
thought was fixed, and I'm now a tad worried (seeing this reappear) that
someone has restored it back to an earlier version.

Peter

--
Peter Mount peter@retep.org.uk
PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/

Re: Current CVS in a bad state?

From
The Hermit Hacker
Date:
No restore on this happened, as far as a backup is concerned ... is it
possible that  your removed it on your side, and failed to do a 'cvs
delete' in the respository?

On Fri, 20 Apr 2001, Peter T Mount wrote:

> Hmmm, I've just checked out the current cvs, and the directory:
>
>   src/interfaces/jdbc/postgresql
>
> has reappeared. This was deleted quite a few months ago and is obsolete. Any
> ideas on how this got back in?
>
> Was there a restore of some kind made? I'm looking into a bug report which I
> thought was fixed, and I'm now a tad worried (seeing this reappear) that
> someone has restored it back to an earlier version.
>
> Peter
>
> --
> Peter Mount peter@retep.org.uk
> PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
> RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org


Re: Current CVS in a bad state?

From
Tom Lane
Date:
Peter T Mount <peter@retep.org.uk> writes:
> Hmmm, I've just checked out the current cvs, and the directory:
>   src/interfaces/jdbc/postgresql
> has reappeared. This was deleted quite a few months ago and is
> obsolete.

Did you use -P during the checkout?

            regards, tom lane

Re: Current CVS in a bad state?

From
Peter T Mount
Date:
Quoting Tom Lane <tgl@sss.pgh.pa.us>:

> Peter T Mount <peter@retep.org.uk> writes:
> > Hmmm, I've just checked out the current cvs, and the directory:
> >   src/interfaces/jdbc/postgresql
> > has reappeared. This was deleted quite a few months ago and is
> > obsolete.
>
> Did you use -P during the checkout?

No, but then the last time I did this (about a month ago) I didn't then either.

As I just said to Marc, I remember the directory being deleted on the server
side after I had done a cvs delete.

Peter

>
>             regards, tom lane
>



--
Peter Mount peter@retep.org.uk
PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/

Re: Current CVS in a bad state?

From
Peter T Mount
Date:
Quoting The Hermit Hacker <scrappy@hub.org>:

>
> No restore on this happened, as far as a backup is concerned ... is it
> possible that  your removed it on your side, and failed to do a 'cvs
> delete' in the respository?

No, as I remember someone physically deleting it as well as it being removed by
a "cvs delete". In fact I think it was Bruce.

Anyhow that directory should go as it's the old 6.5.3 source.

BTW: I discovered it as I'm using Rational Rose here at IS, so for practice
purposes I'm creating a rose model of the JDBC driver...

Peter

>
> On Fri, 20 Apr 2001, Peter T Mount wrote:
>
> > Hmmm, I've just checked out the current cvs, and the directory:
> >
> >   src/interfaces/jdbc/postgresql
> >
> > has reappeared. This was deleted quite a few months ago and is
> obsolete. Any
> > ideas on how this got back in?
> >
> > Was there a restore of some kind made? I'm looking into a bug report
> which I
> > thought was fixed, and I'm now a tad worried (seeing this reappear)
> that
> > someone has restored it back to an earlier version.
> >
> > Peter
> >
> > --
> > Peter Mount peter@retep.org.uk
> > PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
> > RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/
> >
> > ---------------------------(end of
> broadcast)---------------------------
> > TIP 4: Don't 'kill -9' the postmaster
> >
>
> Marc G. Fournier                   ICQ#7615664               IRC Nick:
> Scrappy
> Systems Administrator @ hub.org
> primary: scrappy@hub.org           secondary:
> scrappy@{freebsd|postgresql}.org
>
>



--
Peter Mount peter@retep.org.uk
PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/

Re: Current CVS in a bad state?

From
Tom Lane
Date:
Peter T Mount <peter@retep.org.uk> writes:
> Quoting Tom Lane <tgl@sss.pgh.pa.us>:
>> Did you use -P during the checkout?

> No, but then the last time I did this (about a month ago) I didn't then either.

That's why it reappeared, then.

> As I just said to Marc, I remember the directory being deleted on the server
> side after I had done a cvs delete.

CVS *never* deletes a server-side directory.  Read the manual.

I don't know why -P isn't the standard behavior, because the default
(non -P) is confusing and almost never what you want.  I keep this in
my ~/.cvsrc:

cvs -z3
update -d -P
checkout -P

            regards, tom lane

Re: Current CVS in a bad state?

From
Peter T Mount
Date:
Quoting Tom Lane <tgl@sss.pgh.pa.us>:

> Peter T Mount <peter@retep.org.uk> writes:
> > Quoting Tom Lane <tgl@sss.pgh.pa.us>:
> >> Did you use -P during the checkout?
>
> > No, but then the last time I did this (about a month ago) I didn't
> then either.
>
> That's why it reappeared, then.

The last checkout I did didn't have it, which is the weird part (every so often
I do a fresh checkout rather than a simple update), which is why I thought
something was awry when the directories reappeared.

> > As I just said to Marc, I remember the directory being deleted on the
> server
> > side after I had done a cvs delete.
>
> CVS *never* deletes a server-side directory.  Read the manual.

I know but I remember someone (I think it was Bruce, but not certain) did
a "rm" at the server side.

> I don't know why -P isn't the standard behavior, because the default
> (non -P) is confusing and almost never what you want.  I keep this in
> my ~/.cvsrc:
>
> cvs -z3
> update -d -P
> checkout -P

Mine's that now.

Peter

--
Peter Mount peter@retep.org.uk
PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/

Re: Current CVS in a bad state?

From
Tom Lane
Date:
Peter T Mount <peter@retep.org.uk> writes:
>> CVS *never* deletes a server-side directory.  Read the manual.

> I know but I remember someone (I think it was Bruce, but not certain) did
> a "rm" at the server side.

If so, he should be shot --- that would mean permanent loss of the
history for what had been in that directory.  The only reason I can
see for doing such a thing would be if you'd made the CVS directory
by accident and it had never contained any actual CVS files.

However, given that the directory is still there and does still contain
files, it doesn't appear than anyone actually did any such thing ...

            regards, tom lane

Re: Re: Current CVS in a bad state?

From
Bruce Momjian
Date:
> > > As I just said to Marc, I remember the directory being deleted on the
> > server
> > > side after I had done a cvs delete.
> >
> > CVS *never* deletes a server-side directory.  Read the manual.
>
> I know but I remember someone (I think it was Bruce, but not certain) did
> a "rm" at the server side.

I did remove the jdbc/postgres directory via cvs at your request, but
did not remove it from the server side.  Such removals are limited to
extreme circumastances, like when we want to create a file and there is
an old directory with the same name in the way.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Current CVS in a bad state?

From
Bruce Momjian
Date:
> > As I just said to Marc, I remember the directory being deleted on the server
> > side after I had done a cvs delete.
>
> CVS *never* deletes a server-side directory.  Read the manual.
>
> I don't know why -P isn't the standard behavior, because the default
> (non -P) is confusing and almost never what you want.  I keep this in
> my ~/.cvsrc:
>
> cvs -z3
> update -d -P
> checkout -P

Totally agree.  -P activity should be the default.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Current CVS in a bad state?

From
The Hermit Hacker
Date:
On Fri, 20 Apr 2001, Peter T Mount wrote:

> Quoting Tom Lane <tgl@sss.pgh.pa.us>:
>
> > Peter T Mount <peter@retep.org.uk> writes:
> > > Hmmm, I've just checked out the current cvs, and the directory:
> > >   src/interfaces/jdbc/postgresql
> > > has reappeared. This was deleted quite a few months ago and is
> > > obsolete.
> >
> > Did you use -P during the checkout?
>
> No, but then the last time I did this (about a month ago) I didn't then either.
>
> As I just said to Marc, I remember the directory being deleted on the server
> side after I had done a cvs delete.

don't scare me like that, eh? :)  nothing should ever be 'physically'
removed:

hub# du
19      ./fastpath/Attic
20      ./fastpath
197     ./jdbc1/Attic
198     ./jdbc1
27      ./geometric/Attic
28      ./geometric
19      ./largeobject/Attic
20      ./largeobject
58      ./util/Attic
59      ./util
220     ./jdbc2/Attic
221     ./jdbc2
489     ./Attic
1036    .

but you have to use the -P option if you don't want to see 'deleted' files
...

I always run either:

cvs checkout -P <module>

or

cvs update -APd <module>

I think -A removes teh sticky bit, so if you are working on an older
release, don't use -A :)