Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgsql/src/backend/access/transam xlog.c

pgsql/src/backend/access/transam xlog.c

From
Tom Lane
Date:
CVSROOT:    /home/projects/pgsql/cvsroot
Module name:    pgsql
Changes by:    tgl@hub.org    01/03/14 15:23:04

Modified files:
    src/backend/access/transam: xlog.c

Log message:
    Use SEP_CHAR consistently in forming XLOG pathnames.

Re: pgsql/src/backend/access/transam xlog.c

From
Peter Eisentraut
Date:
Tom Lane writes:

> Log message:
>     Use SEP_CHAR consistently in forming XLOG pathnames.

Do we need the SEP_CHAR at all?  No platform uses something different.
Even Windows works with '/'.

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/

Re: pgsql/src/backend/access/transam xlog.c

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane writes:
>> Use SEP_CHAR consistently in forming XLOG pathnames.

> Do we need the SEP_CHAR at all?  No platform uses something different.
> Even Windows works with '/'.

Somebody evidently once thought that we needed '\' on NT.  I'm not sure
if it's really necessary or not.

In any case, this is no time to be removing all the uses of SEP_CHAR.
Put it on your todo list for 7.2 if you like ...

            regards, tom lane