Thread: pgsql/src/backend/commands (creatinh.c)

pgsql/src/backend/commands (creatinh.c)

From
tgl@postgresql.org
Date:
  Date: Wednesday, December 13, 2000 @ 19:41:09
Author: tgl

Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/commands
     from hub.org:/home/projects/pgsql/tmp/cvs-serv67536

Modified Files:
    creatinh.c

-----------------------------  Log Message  -----------------------------

Change StoreCatalogInheritance() to work from a list of parent relation
OIDs rather than names.  Aside from being simpler and faster, this way
doesn't blow up in the face of 'create temp table foo () inherits (foo)'.
Which is a rather odd thing to do, but it seems some people want to.

Re: pgsql/src/backend/commands (creatinh.c)

From
Peter Eisentraut
Date:
tgl@postgresql.org writes:

> Change StoreCatalogInheritance() to work from a list of parent relation
> OIDs rather than names.  Aside from being simpler and faster, this way
> doesn't blow up in the face of 'create temp table foo () inherits (foo)'.
> Which is a rather odd thing to do, but it seems some people want to.

Just wondering, is the "odd" thing here the 'temp', the empty column list,
or 2 times "foo"?

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/


Re: pgsql/src/backend/commands (creatinh.c)

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> tgl@postgresql.org writes:
>> Change StoreCatalogInheritance() to work from a list of parent relation
>> OIDs rather than names.  Aside from being simpler and faster, this way
>> doesn't blow up in the face of 'create temp table foo () inherits (foo)'.
>> Which is a rather odd thing to do, but it seems some people want to.

> Just wondering, is the "odd" thing here the 'temp', the empty column list,
> or 2 times "foo"?

The latter.  The failure case was

    create table foo (...);
    create temp table foo (...) inherits (foo);

the problem being that the temp table name mapping for the temp foo
was installed before we were done looking up its ancestors.

            regards, tom lane