Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgsql (GNUmakefile.in)

pgsql (GNUmakefile.in)

From
tgl@postgresql.org
Date:
  Date: Sunday, December  3, 2000 @ 19:34:40
Author: tgl

Update of /home/projects/pgsql/cvsroot/pgsql
     from hub.org:/home/projects/pgsql/tmp/cvs-serv7999

Modified Files:
    GNUmakefile.in

-----------------------------  Log Message  -----------------------------

Seems like make clean or make distclean should clean out contrib
directories too, not only src and doc.

Re: pgsql (GNUmakefile.in)

From
Peter Eisentraut
Date:
tgl@postgresql.org writes:

> Seems like make clean or make distclean should clean out contrib
> directories too, not only src and doc.

Theoretically 'make clean' should clean out what was build by 'make all',
but no more.  Not sure about this one...

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/

Re: pgsql (GNUmakefile.in)

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> tgl@postgresql.org writes:
>> Seems like make clean or make distclean should clean out contrib
>> directories too, not only src and doc.

> Theoretically 'make clean' should clean out what was build by 'make all',
> but no more.  Not sure about this one...

Counterexample: src/test/regress is cleaned by 'make clean', but not
built by 'make all'.  I think contrib should behave the same.

Certainly distclean should clean out these directories, even if you
think that plain 'make clean' should not.

            regards, tom lane

Re: pgsql (GNUmakefile.in)

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane writes:
>> Counterexample: src/test/regress is cleaned by 'make clean', but not
>> built by 'make all'.  I think contrib should behave the same.

> That's because 'make check' is an exception since you're supposed to run
> that as part of the normal installation procedure.

Yes, and "make distclean" is part of the normal tarball building
procedure.  I want a guarantee that there will be no cruft in the tarball.
If contrib isn't cleaned out then we don't have that guarantee.

> However, the point is that contrib should be separated from the "real"
> source.  Perhaps the makefiles aren't even functioning.  Are we going to
> guarantee that?  Maybe we should, but it wasn't the case in the past.

If "make clean" invokes the same in contrib, we'll quickly find out if
there are any broken "clean" targets in contrib ;-).  This is a lot
different from depending on the contrib stuff to *build*.  You'll note
I did not propose that toplevel "make all" should recurse into contrib...

            regards, tom lane

Re: pgsql (GNUmakefile.in)

From
Peter Eisentraut
Date:
Tom Lane writes:

> > Theoretically 'make clean' should clean out what was build by 'make all',
> > but no more.  Not sure about this one...
>
> Counterexample: src/test/regress is cleaned by 'make clean', but not
> built by 'make all'.  I think contrib should behave the same.

That's because 'make check' is an exception since you're supposed to run
that as part of the normal installation procedure.

However, the point is that contrib should be separated from the "real"
source.  Perhaps the makefiles aren't even functioning.  Are we going to
guarantee that?  Maybe we should, but it wasn't the case in the past.
And then what's contrib for?

> Certainly distclean should clean out these directories, even if you
> think that plain 'make clean' should not.

distclean = clean + rm config.status output -- theoretically again :)

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/