Thread: pgsql/src (Makefile.global.in)

  Date: Monday, November 20, 2000 @ 00:18:38
Author: vadim

Update of /home/projects/pgsql/cvsroot/pgsql/src
     from hub.org:/home/projects/pgsql/tmp/cvs-serv24642/src

Modified Files:
    Makefile.global.in

-----------------------------  Log Message  -----------------------------

Compile WAL by default.

vadim@postgresql.org writes:

*** 145,150 ****
--- 145,152 ----
  ifeq ($(GCC), yes)
    CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
  endif
+
+ CFLAGS += -DXLOG

  CXX = @CXX@
  GXX = @GXX@

Ick.  Couldn't we do this by #define XLOG in config.h.in, instead?
CFLAGS are horribly vulnerable to people overriding them with
make options.

I do recall that when I last tried to build with WAL, my attempt
to add #define XLOG to config.h failed --- but that indicates poor
coding practices elsewhere.  It *should* work to add or remove a
feature symbol in config.h.

            regards, tom lane

Tom Lane writes:

> vadim@postgresql.org writes:
>
> *** 145,150 ****
> --- 145,152 ----
>   ifeq ($(GCC), yes)
>     CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
>   endif
> +
> + CFLAGS += -DXLOG

(Should be CPPFLAGS anyway.)

>
>   CXX = @CXX@
>   GXX = @GXX@
>
> Ick.  Couldn't we do this by #define XLOG in config.h.in, instead?
> CFLAGS are horribly vulnerable to people overriding them with
> make options.
>
> I do recall that when I last tried to build with WAL, my attempt
> to add #define XLOG to config.h failed --- but that indicates poor
> coding practices elsewhere.  It *should* work to add or remove a
> feature symbol in config.h.

Surely checking #ifdef XLOG before including postgres.h won't help.  Fix
coming in right now.

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/