Thread: pgsql (Makefile)
Date: Monday, June 12, 2000 @ 12:05:25
Author: momjian
Update of /home/projects/pgsql/cvsroot/pgsql
from hub.org:/home/projects/pgsql/tmp/cvs-serv37892/pgsql
Removed Files:
Makefile
----------------------------- Log Message -----------------------------
Remove Makefile. Now generated by configure.
Bruce Momjian - CVS <momjian@hub.org> writes:
> Remove Makefile. Now generated by configure.
Bruce, what in the world are you doing? There was a perfectly good
hand-generated Makefile in that directory.
regards, tom lane
> Bruce Momjian - CVS <momjian@hub.org> writes: > > Remove Makefile. Now generated by configure. > > Bruce, what in the world are you doing? There was a perfectly good > hand-generated Makefile in that directory. Seems Peter now creates Makefile as part of configure. However, he does not create on in the top level directory, which we all think is needed too, not just in /src. OK, now I am really confused about what Peter wants. I don't see Makefile being created by configure. I am re-adding pgsql/Makefile, and keeping src/Makefile. Peter, can you comment? -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
I have put back the old pgsql/Makefile, and added the same one to /src. > Bruce Momjian - CVS <momjian@hub.org> writes: > > Remove Makefile. Now generated by configure. > > Bruce, what in the world are you doing? There was a perfectly good > hand-generated Makefile in that directory. > > regards, tom lane > -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I have put back the old pgsql/Makefile, and added the same one to /src.
OK. I think your commit messages arrived here out-of-order ...
I was confused about what was happening.
regards, tom lane
> Bruce Momjian <pgman@candle.pha.pa.us> writes: > > I have put back the old pgsql/Makefile, and added the same one to /src. > > OK. I think your commit messages arrived here out-of-order ... > I was confused about what was happening. Seems the problem is that src/Makefile disappeared, and I thought Peter was saying he auto-generated them from configure. Actually, they are just beefed up. -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> Bruce Momjian <pgman@candle.pha.pa.us> writes:
>>>> I have put back the old pgsql/Makefile, and added the same one to /src.
>>
>> OK. I think your commit messages arrived here out-of-order ...
>> I was confused about what was happening.
> Seems the problem is that src/Makefile disappeared, and I thought Peter
> was saying he auto-generated them from configure. Actually, they are
> just beefed up.
Yes, the top-level Makefile still has the same old purpose of catching
people who try to use non-GNU make. It's not auto-generated.
I think Peter was in error to remove src/Makefile --- it will still have
the same purpose, but for people who remember the old build procedure of
starting in pgsql/src.
Looks like things are good now.
regards, tom lane
On Mon, 12 Jun 2000, Bruce Momjian wrote: > I am re-adding pgsql/Makefile, and keeping src/Makefile. Peter, can you > comment? There should definitely be one in pgsql/Makefile and if you like for "backward compatibility" one in src/Makefile. The problem was that Bruce apparently overwrote the new "fancy" version with the old one at one point. The one that's in there now is good. -- Peter Eisentraut Sernanders väg 10:115 peter_e@gmx.net 75262 Uppsala http://yi.org/peter-e/ Sweden