Thread: BUG #2091: ecpglib.h needs to be updated....

BUG #2091: ecpglib.h needs to be updated....

From
"Chuck Wegrzyn"
Date:
The following bug has been logged online:

Bug reference:      2091
Logged by:          Chuck Wegrzyn
Email address:      lists@garbagedump.com
PostgreSQL version: 8.1.0
Operating system:   Linux
Description:        ecpglib.h needs to be updated....
Details:

There are a number of places in function prototypes of ECPGdo, ECPGprepare
and ECPGdeallocate where 'char *' should be changed to 'const char *'. I am
sure the other functions have similar problems.

In trying to get my make's to work cleanly (no spurious warnings), I put
-fwriteable-string as an option. But this is a deprecated option in gcc,
which spits out a complaint. So the only way to stop the madness is to cast
the function prototypes correctly. Is this a possibility for the next
release (or is it in there already)?

Re: BUG #2091: ecpglib.h needs to be updated....

From
Bruce Momjian
Date:
This will be fixed when we release 8.1.1, which is planned for next
week.  Before then, you can grab from CVS using the 8.1 tag.

---------------------------------------------------------------------------

Chuck Wegrzyn wrote:
>
> The following bug has been logged online:
>
> Bug reference:      2091
> Logged by:          Chuck Wegrzyn
> Email address:      lists@garbagedump.com
> PostgreSQL version: 8.1.0
> Operating system:   Linux
> Description:        ecpglib.h needs to be updated....
> Details:
>
> There are a number of places in function prototypes of ECPGdo, ECPGprepare
> and ECPGdeallocate where 'char *' should be changed to 'const char *'. I am
> sure the other functions have similar problems.
>
> In trying to get my make's to work cleanly (no spurious warnings), I put
> -fwriteable-string as an option. But this is a deprecated option in gcc,
> which spits out a complaint. So the only way to stop the madness is to cast
> the function prototypes correctly. Is this a possibility for the next
> release (or is it in there already)?
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: BUG #2091: ecpglib.h needs to be updated....

From
Tom Lane
Date:
"Chuck Wegrzyn" <lists@garbagedump.com> writes:
> There are a number of places in function prototypes of ECPGdo, ECPGprepare
> and ECPGdeallocate where 'char *' should be changed to 'const char *'.

This was already addressed:
http://archives.postgresql.org/pgsql-committers/2005-12/msg00008.php

Do you see anything missed by that patch?

            regards, tom lane