Postgres Pro
Downloads
Home   >   mailing lists

Thread: BUG #1219: pgxs does not work fully

BUG #1219: pgxs does not work fully

From
"PostgreSQL Bugs List"
Date:
The following bug has been logged online:

Bug reference:      1219
Logged by:          Fabien COELHO

Email address:      coelho@cri.ensmp.fr

PostgreSQL version: 8.0 Beta

Operating system:   Linux debian

Description:        pgxs does not work fully

Details:

When testing the pgxs framework with various contribs,
some (at least pgbench) do not compile because:

(1) missing file: libpgport.*

(2) non adapted macros: libpq_*dir

(3) testing the feature is not easy because
    the makefiles in contrib do not allow to use it,
    so one has to fix the makefiles first.

Moreover I really think that even if Peter finds it useless it should be
allowed to use pgxs for contribs
especially as it may be useful to others and as it
does not necessarily harm.

I'm planing to submit yet another patch so as to fix
this again while still preserving the vpath behavior.

Re: [PATCHES] BUG #1219: pgxs does not work fully

From
Peter Eisentraut
Date:
Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO:
> The patch adds missing the "libpgport.a" file to the installation under
> "install-all-headers". It is needed by some contribs. I install the
> library in "pkglibdir", but I was wondering whether it should be "libdir"?

Yes it should.  Please change it.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Re: [PATCHES] BUG #1219: pgxs does not work fully

From
Fabien COELHO
Date:
> Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO:
> > The patch adds missing the "libpgport.a" file to the installation under
> > "install-all-headers". It is needed by some contribs. I install the
> > library in "pkglibdir", but I was wondering whether it should be "libdir"?
>
> Yes it should.  Please change it.

Dear Peter, dear patchers,

Please find attached a small patch against current CVS head that fixes
pgport library installation so that it goes to libdir instead of
pkglibdir. It works for me.

Have a nice day,

--
Fabien Coelho - coelho@cri.ensmp.fr

Re: [PATCHES] BUG #1219: pgxs does not work fully

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Fabien COELHO wrote:
>
> > Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO:
> > > The patch adds missing the "libpgport.a" file to the installation under
> > > "install-all-headers". It is needed by some contribs. I install the
> > > library in "pkglibdir", but I was wondering whether it should be "libdir"?
> >
> > Yes it should.  Please change it.
>
> Dear Peter, dear patchers,
>
> Please find attached a small patch against current CVS head that fixes
> pgport library installation so that it goes to libdir instead of
> pkglibdir. It works for me.
>
> Have a nice day,
>
> --
> Fabien Coelho - coelho@cri.ensmp.fr

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073