Thread: Freeze when trying to run a pg_dump backup file as SQL query

Freeze when trying to run a pg_dump backup file as SQL query

From

Evan Martin

Date:

06 July 2012, 12:33:49

I've reliably reproduced the freezing bug I mentioned before (in the 
suggestion to save query text). pgAdmin freezes when I try to run a 
backup file created by pg_dump from an SQL query window. The file 
contents look like this:

COPY much_data (some_data) FROM stdin;
BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
\.

When I run that the output window shows:

ERROR:  syntax error at or near "BLAH"
LINE 2: BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/...

That's fine (well, it would be nice if pgAdmin supported restoring such 
files, but that's another story) - but then it freezes. It doesn't 
happen with 5 lines as above, but if I have 100 lines of data that's 
enough to make it freeze for a few seconds. With a real back-up file of 
1 MB or more it probably won't come back any time soon and has to be 
killed. (It doesn't need to be real data - just copy/paste the 5 BLAH 
lines above 20 times to reproduce the problem.)

I'm running pgAdmin 1.14.3 running on Windows 7 (x64), PostgreSQL 9.1.3

Regards,

Evan

Re: Freeze when trying to run a pg_dump backup file as SQL query

From

Evan Martin

Date:

13 July 2012, 15:27:06

No comments at all? Can anyone else at least repro this?

On 6/07/2012 10:33 PM, Evan Martin wrote:
> I've reliably reproduced the freezing bug I mentioned before (in the 
> suggestion to save query text). pgAdmin freezes when I try to run a 
> backup file created by pg_dump from an SQL query window. The file 
> contents look like this:
>
> COPY much_data (some_data) FROM stdin;
> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> \.
>
> When I run that the output window shows:
>
> ERROR:  syntax error at or near "BLAH"
> LINE 2: BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/...
>
> That's fine (well, it would be nice if pgAdmin supported restoring 
> such files, but that's another story) - but then it freezes. It 
> doesn't happen with 5 lines as above, but if I have 100 lines of data 
> that's enough to make it freeze for a few seconds. With a real back-up 
> file of 1 MB or more it probably won't come back any time soon and has 
> to be killed. (It doesn't need to be real data - just copy/paste the 5 
> BLAH lines above 20 times to reproduce the problem.)
>
> I'm running pgAdmin 1.14.3 running on Windows 7 (x64), PostgreSQL 9.1.3
>
> Regards,
>
> Evan
>

Re: Freeze when trying to run a pg_dump backup file as SQL query

From

Raymond O'Donnell

Date:

13 July 2012, 15:51:01

On 13/07/2012 16:26, Evan Martin wrote:
> No comments at all? Can anyone else at least repro this?
> 
> On 6/07/2012 10:33 PM, Evan Martin wrote:
>> I've reliably reproduced the freezing bug I mentioned before (in the
>> suggestion to save query text). pgAdmin freezes when I try to run a
>> backup file created by pg_dump from an SQL query window. The file
>> contents look like this:
>>
>> COPY much_data (some_data) FROM stdin;
>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>> \.
>>
>> When I run that the output window shows:
>>
>> ERROR:  syntax error at or near "BLAH"
>> LINE 2: BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/...
>>
>> That's fine (well, it would be nice if pgAdmin supported restoring
>> such files, but that's another story) - but then it freezes. It
>> doesn't happen with 5 lines as above, but if I have 100 lines of data
>> that's enough to make it freeze for a few seconds. With a real back-up
>> file of 1 MB or more it probably won't come back any time soon and has
>> to be killed. (It doesn't need to be real data - just copy/paste the 5
>> BLAH lines above 20 times to reproduce the problem.)
>>
>> I'm running pgAdmin 1.14.3 running on Windows 7 (x64), PostgreSQL 9.1.3

Is there anything at all happening with pgAdmin while the query is
running? Is the timer in the lower right corner of the window incrementing?

You probably know this, but just in case: plain-text backup files from
pg_dump don't as a rule work in a pgAdmin query window, as they contain
various psql-specific backslash commands that pgAdmin doesn't handle;
pipe the file to psql instead. pgAdmin does, however, handle
binary-format pg_dump files; select "restore" from a right-click menu in
the tree view.

Ray.

-- 
Raymond O'Donnell :: Galway :: Ireland
rod@iol.ie

Re: Freeze when trying to run a pg_dump backup file as SQL query

From

Guillaume Lelarge

Date:

14 July 2012, 12:46:50

On Sat, 2012-07-14 at 01:26 +1000, Evan Martin wrote:
> No comments at all? Can anyone else at least repro this?
> 

Don't know for others, but I was overloaded translating in french the
PostgreSQL 9.2 manual. Now that's it's done, I can get back on hacking
pgAdmin.

> On 6/07/2012 10:33 PM, Evan Martin wrote:
> > I've reliably reproduced the freezing bug I mentioned before (in the 
> > suggestion to save query text). pgAdmin freezes when I try to run a 
> > backup file created by pg_dump from an SQL query window. The file 
> > contents look like this:
> >
> > COPY much_data (some_data) FROM stdin;
> > BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> > BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> > BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> > BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> > BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
> > \.
> >
> > When I run that the output window shows:
> >
> > ERROR:  syntax error at or near "BLAH"
> > LINE 2: BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/...
> >
> > That's fine (well, it would be nice if pgAdmin supported restoring 
> > such files, but that's another story) - but then it freezes. It 
> > doesn't happen with 5 lines as above, but if I have 100 lines of data 
> > that's enough to make it freeze for a few seconds. With a real back-up 
> > file of 1 MB or more it probably won't come back any time soon and has 
> > to be killed. (It doesn't need to be real data - just copy/paste the 5 
> > BLAH lines above 20 times to reproduce the problem.)
> >
> > I'm running pgAdmin 1.14.3 running on Windows 7 (x64), PostgreSQL 9.1.3
> >

I reproduce this with something around 400 lines. We used an very
inefficient way to find the part of the query that was wrong, to
highlight it. This is now fixed in 1.16, and master branches.


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

Re: Freeze when trying to run a pg_dump backup file as SQL query

From

Evan Martin

Date:

15 July 2012, 04:01:31

Great, thanks for the fix, Guillaume! I tested it the latest master 
version with my original 15 MB file and it no longer freezes even on 
that. (It does take a few seconds just to open the file, but that's OK.)

Regards,

Evan

On 14/07/2012 10:46 PM, Guillaume Lelarge wrote:
> On Sat, 2012-07-14 at 01:26 +1000, Evan Martin wrote:
>> No comments at all? Can anyone else at least repro this?
>>
> Don't know for others, but I was overloaded translating in french the
> PostgreSQL 9.2 manual. Now that's it's done, I can get back on hacking
> pgAdmin.
>
>> On 6/07/2012 10:33 PM, Evan Martin wrote:
>>> I've reliably reproduced the freezing bug I mentioned before (in the
>>> suggestion to save query text). pgAdmin freezes when I try to run a
>>> backup file created by pg_dump from an SQL query window. The file
>>> contents look like this:
>>>
>>> COPY much_data (some_data) FROM stdin;
>>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>>> BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH
>>> \.
>>>
>>> When I run that the output window shows:
>>>
>>> ERROR:  syntax error at or near "BLAH"
>>> LINE 2: BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/BLAH/...
>>>
>>> That's fine (well, it would be nice if pgAdmin supported restoring
>>> such files, but that's another story) - but then it freezes. It
>>> doesn't happen with 5 lines as above, but if I have 100 lines of data
>>> that's enough to make it freeze for a few seconds. With a real back-up
>>> file of 1 MB or more it probably won't come back any time soon and has
>>> to be killed. (It doesn't need to be real data - just copy/paste the 5
>>> BLAH lines above 20 times to reproduce the problem.)
>>>
>>> I'm running pgAdmin 1.14.3 running on Windows 7 (x64), PostgreSQL 9.1.3
>>>
> I reproduce this with something around 400 lines. We used an very
> inefficient way to find the part of the query that was wrong, to
> highlight it. This is now fixed in 1.16, and master branches.
>
>