Thread: Domain wizard bug

Domain wizard bug

From
** **
Date:
Problem occur when I have more than one schema.
When I create domain for TEST_SCHEMA and set owner, pgadmin add the line:
ALTER DOMAIN "PT2" OWNER TO postgres; and I get error.
It Should be:
ALTER DOMAIN test_schema."PT2" OWNER TO postgres; but schema name isnot 
consider.


sory for my english.


Re: Domain wizard bug

From
Dave Page
Date:
2009/8/23 ** ** <banita21@gmail.com>:
> Problem occur when I have more than one schema.
> When I create domain for TEST_SCHEMA and set owner, pgadmin add the line:
> ALTER DOMAIN "PT2" OWNER TO postgres; and I get error.
> It Should be:
> ALTER DOMAIN test_schema."PT2" OWNER TO postgres; but schema name isnot consider.
>
>
> sory for my english.

Thanks for the report. I've fixed the bug and will commit the patch as
soon as I have net access.

-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com


Re: Domain wizard bug

From
Guillaume Lelarge
Date:
Le mardi 25 août 2009 à 02:33:10, Dave Page a écrit :
> 2009/8/23 ** ** <banita21@gmail.com>:
> > Problem occur when I have more than one schema.
> > When I create domain for TEST_SCHEMA and set owner, pgadmin add the line:
> > ALTER DOMAIN "PT2" OWNER TO postgres; and I get error.
> > It Should be:
> > ALTER DOMAIN test_schema."PT2" OWNER TO postgres; but schema name isnot
> > consider.
> >
> >
> > sory for my english.
>
> Thanks for the report. I've fixed the bug and will commit the patch as
> soon as I have net access.

Dave, I suppose you forgot about this one. Or did I miss the commit?


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com


Re: Domain wizard bug

From
Dave Page
Date:
On Tue, Sep 1, 2009 at 1:00 PM, Guillaume Lelarge<guillaume@lelarge.info> wrote:
> Le mardi 25 août 2009 à 02:33:10, Dave Page a écrit :
>> 2009/8/23 ** ** <banita21@gmail.com>:
>> > Problem occur when I have more than one schema.
>> > When I create domain for TEST_SCHEMA and set owner, pgadmin add the line:
>> > ALTER DOMAIN "PT2" OWNER TO postgres; and I get error.
>> > It Should be:
>> > ALTER DOMAIN test_schema."PT2" OWNER TO postgres; but schema name isnot
>> > consider.
>> >
>> >
>> > sory for my english.
>>
>> Thanks for the report. I've fixed the bug and will commit the patch as
>> soon as I have net access.
>
> Dave, I suppose you forgot about this one. Or did I miss the commit?

I forgot. What's worse is that I also cleaned out a bunch of patches I
had hanging around, including that one. D'oh!

It's committed now anyway - and I'm now wishing we were using GIT more
than ever!


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com


Re: Domain wizard bug

From
Guillaume Lelarge
Date:
Le mardi 1 septembre 2009 à 14:30:09, Dave Page a écrit :
> On Tue, Sep 1, 2009 at 1:00 PM, Guillaume Lelarge<guillaume@lelarge.info>
wrote:
> > Le mardi 25 août 2009 à 02:33:10, Dave Page a écrit :
> >> 2009/8/23 ** ** <banita21@gmail.com>:
> >> > Problem occur when I have more than one schema.
> >> > When I create domain for TEST_SCHEMA and set owner, pgadmin add the
> >> > line: ALTER DOMAIN "PT2" OWNER TO postgres; and I get error.
> >> > It Should be:
> >> > ALTER DOMAIN test_schema."PT2" OWNER TO postgres; but schema name
> >> > isnot consider.
> >> >
> >> >
> >> > sory for my english.
> >>
> >> Thanks for the report. I've fixed the bug and will commit the patch as
> >> soon as I have net access.
> >
> > Dave, I suppose you forgot about this one. Or did I miss the commit?
>
> I forgot. What's worse is that I also cleaned out a bunch of patches I
> had hanging around, including that one. D'oh!
>

Ouch. No backups?

> It's committed now anyway - and I'm now wishing we were using GIT more
> than ever!

Great, thanks. GIT would be cool, I'd love to know more about it (I mean "use
it" more than "know it").


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com


Re: Domain wizard bug

From
Dave Page
Date:
On Tue, Sep 1, 2009 at 1:35 PM, Guillaume Lelarge<guillaume@lelarge.info> wrote:
>> I forgot. What's worse is that I also cleaned out a bunch of patches I
>> had hanging around, including that one. D'oh!
>>
>
> Ouch. No backups?

Actually I found a copy of the modified file in the trash - but it was
only a 2 liner. No backups, because I didn't plug in my external drive
while I was away, so time machine didn't do it's thing.

>> It's committed now anyway - and I'm now wishing we were using GIT more
>> than ever!
>
> Great, thanks. GIT would be cool, I'd love to know more about it (I mean "use
> it" more than "know it").

:-).

It would make working offline on multiple long-term projects *far*
easier. No more keeping multiple copies of the tree, or diffs to get
deleted by mistake...

-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com