Thread: bug report

bug report

From
Sim Zacks
Date:
This is a bug I reported a number of versions back, but it is still
here.
1.6 Beta 1
If you restore a database and there are warnings when you click OK it
tries to do the backup again. You have to click Cancel, which is
counter intuitive.

Thank You
Sim Zacks
IT Manager
CompuLab
04-829-0145 - Office
04-832-5251 - Fax



Re: bug report

From
"Dave Page"
Date:

> -----Original Message-----
> From: pgadmin-support-owner@postgresql.org
> [mailto:pgadmin-support-owner@postgresql.org] On Behalf Of Sim Zacks
> Sent: 20 September 2006 15:26
> To: pgadmin-support@postgresql.org
> Subject: [pgadmin-support] bug report
>
> This is a bug I reported a number of versions back, but it is still
> here.
> 1.6 Beta 1
> If you restore a database and there are warnings when you click OK it
> tries to do the backup again. You have to click Cancel, which is
> counter intuitive.

The design is intended to allow you to modify options and try again, or
to cancel the whole operation. I'm not sure how that's any different
from any of the other dialogues - click the OK button and an attempt is
made to create an object for example - if an error occurs you can change
options and try OK again, or hit Cancel to abort.

Regards, Dave.


Re: bug report

From
Sim Zacks
Date:
> The design is intended to allow you to modify options and try again, or
> to cancel the whole operation. I'm not sure how that's any different
> from any of the other dialogues - click the OK button and an attempt is
> made to create an object for example - if an error occurs you can change
> options and try OK again, or hit Cancel to abort.

The difference is when there are only warnings, that means the restore
was completed. If you click OK then it will try to restore it again
over the restore that you already did, which will either completely
fail, causing confusion as to exactly what happened or somehow import
again causing untold grief.

Sim



Re: bug report

From
"Dave Page"
Date:

> -----Original Message-----
> From: pgadmin-support-owner@postgresql.org
> [mailto:pgadmin-support-owner@postgresql.org] On Behalf Of Sim Zacks
> Sent: 25 September 2006 06:51
> To: pgadmin-support@postgresql.org
> Subject: Re: [pgadmin-support] bug report
>
> > The design is intended to allow you to modify options and
> try again, or
> > to cancel the whole operation. I'm not sure how that's any different
> > from any of the other dialogues - click the OK button and
> an attempt is
> > made to create an object for example - if an error occurs
> you can change
> > options and try OK again, or hit Cancel to abort.
>
> The difference is when there are only warnings, that means the restore
> was completed. If you click OK then it will try to restore it again
> over the restore that you already did, which will either completely
> fail, causing confusion as to exactly what happened or somehow import
> again causing untold grief.

We don't know whether there have been errors or warnings though - we
rely on the return value from pg_restore to tell us if the restore has
been successful or not. I'm not even sure if we can grep the output for
'ERROR' because that may be localised.

Regards, Dave