Thread: [pgAdmin4][Patch]: RM1478 - Paste event is not working in Query tool
Hi
Issue:
On debugging deeply into the code mirror JS library, I found that Ctrl-V event is mapped for "goPageDown" which is the reason paste not working in Mac Runtime.
I have removed this mapping temporary from Code-mirror key map object once code mirror JS library is loaded.
In Mac Runtime, Paste event will work on Cmd-V.
Please find attached patch and review.
Thanks,
Surinder Kumar
Attachment
Awesome job tracking this one down! Thanks, patch applied. On Wed, Sep 14, 2016 at 9:23 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Hi > > Issue: > On debugging deeply into the code mirror JS library, I found that Ctrl-V > event is mapped for "goPageDown" which is the reason paste not working in > Mac Runtime. > > I have removed this mapping temporary from Code-mirror key map object once > code mirror JS library is loaded. > > In Mac Runtime, Paste event will work on Cmd-V. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Wed, Sep 14, 2016 at 3:47 PM, Dave Page <dpage@pgadmin.org> wrote:
Awesome job tracking this one down!
Thanks.
Thanks, patch applied.> --
On Wed, Sep 14, 2016 at 9:23 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Issue:
> On debugging deeply into the code mirror JS library, I found that Ctrl-V
> event is mapped for "goPageDown" which is the reason paste not working in
> Mac Runtime.
>
> I have removed this mapping temporary from Code-mirror key map object once
> code mirror JS library is loaded.
>
> In Mac Runtime, Paste event will work on Cmd-V.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company