Home > mailing lists

Thread: PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4)

PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4)

From

Murtuza Zabuawala

Date:

19 July 2016, 17:15:59

Hi,

PFA patch to fix the issue where user was not able to add/update/drop security labels in various nodes.

(RM#1457)

Affected nodes with this patch,

TABLE --> Fixed

COLUMN --> Fixed

DATABASE --> Fixed

DOMAIN --> Fixed

ROLE --> Fixed

SCHEMA --> Fixed

SEQUENCE --> Fixed

TYPE --> Fixed

VIEW --> Fixed

EVENT TRIGGER --> Fixed

FOREIGN TABLE --> Fixed

FUNCTION --> Fixed

LANGUAGE --> Fixed

Please review.

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

RM_1457.patch

Re: PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4)

From

Dave Page

Date:

21 July 2016, 18:36:10

Hi

On Tue, Jul 19, 2016 at 3:15 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where user was not able to add/update/drop
> security labels in various nodes.
> (RM#1457)

Thanks, applied (with a minor fix to s/LABLE/LABEL/g)

It does need one minor tweak though - the provider field should be
optional; see https://www.postgresql.org/docs/9.4/static/sql-security-label.html.

Can you fix that when you get a minute please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company