Thread: PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)
Hi,
PFA patch to add "Move objects..” functionality in tablespace node.
(RM#1286)
Additionally I have removed pre_9.1 sql's & align SQL line indentation as well.
Please review.
Regards,
Murtuza
Attachment
Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)
From
Dave Page
Date:
Hi On Mon, Jun 13, 2016 at 9:38 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to add "Move objects..” functionality in tablespace node. > (RM#1286) > > Additionally I have removed pre_9.1 sql's & align SQL line indentation as > well. Committed with some minor wording tweaks. Please take care of the following: - Add an SQL tab to the dialogue, showing the SQL that will be executed (like a properties dialogue). - Make it non-modal. - Add Help buttons, and let Susan know what page you need her to write. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)
From
Murtuza Zabuawala
Date:
Hi,
PFA updated patch for comments given over last patch.
Regards,
Murtuza
--
Regards,
On Tue, Jun 14, 2016 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
On Mon, Jun 13, 2016 at 9:38 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to add "Move objects..” functionality in tablespace node.
> (RM#1286)
>
> Additionally I have removed pre_9.1 sql's & align SQL line indentation as
> well.
Committed with some minor wording tweaks. Please take care of the following:
- Add an SQL tab to the dialogue, showing the SQL that will be
executed (like a properties dialogue).
- Make it non-modal.
- Add Help buttons, and let Susan know what page you need her to write.
Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)
From
Dave Page
Date:
Thanks, applies as-is, but please look at the CSS for the SQL tab. There seems to be a small white border around CodeMirror, plus it scrolls vertically a long way without there actually being text overflowing. The above is low priority - please concentrate on higher priority bugs first! On Wed, Jun 15, 2016 at 12:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA updated patch for comments given over last patch. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Jun 14, 2016 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Hi >> >> On Mon, Jun 13, 2016 at 9:38 AM, Murtuza Zabuawala >> <murtuza.zabuawala@enterprisedb.com> wrote: >> > Hi, >> > >> > PFA patch to add "Move objects..” functionality in tablespace node. >> > (RM#1286) >> > >> > Additionally I have removed pre_9.1 sql's & align SQL line indentation >> > as >> > well. >> >> Committed with some minor wording tweaks. Please take care of the >> following: >> >> - Add an SQL tab to the dialogue, showing the SQL that will be >> executed (like a properties dialogue). >> >> - Make it non-modal. >> >> - Add Help buttons, and let Susan know what page you need her to write. >> >> Thanks! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company