Thread: PATCH: Reset view/layout (pgAdmin4)
Hi,
PFA patch to add reset view/layout.
Please review.
RM#1248
---------------
- Additionally, attaching patch to fix validation issue. which was causing statistics tab to break if no node is selected on browser tree and user clicks on statistics tab.
- And also observed an issue with panels causing strange errors which is already fixed by Surinder .(Patch Link)
--
Regards,
Attachment
Hi On Wed, Jun 8, 2016 at 12:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to add reset view/layout. > Please review. > > RM#1248 This needs to go on a different menu (File?), otherwise it won't be accessible when running in desktop mode. > - Additionally, attaching patch to fix validation issue. which was causing > statistics tab to break if no node is selected on browser tree and user > clicks on statistics tab. > - And also observed an issue with panels causing strange errors which is > already fixed by Surinder .(Patch Link) Both committed - thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi,
PFA updated patch, I have shifted it to File menu.
Please review.
Regards,
Murtuza
--
Regards,
On Wed, Jun 8, 2016 at 5:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
On Wed, Jun 8, 2016 at 12:41 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to add reset view/layout.
> Please review.
>
> RM#1248
This needs to go on a different menu (File?), otherwise it won't be
accessible when running in desktop mode.
> - Additionally, attaching patch to fix validation issue. which was causing
> statistics tab to break if no node is selected on browser tree and user
> clicks on statistics tab.
> - And also observed an issue with panels causing strange errors which is
> already fixed by Surinder .(Patch Link)
Both committed - thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks, applied. On Thu, Jun 9, 2016 at 8:47 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA updated patch, I have shifted it to File menu. > Please review. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 8, 2016 at 5:19 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Hi >> >> On Wed, Jun 8, 2016 at 12:41 PM, Murtuza Zabuawala >> <murtuza.zabuawala@enterprisedb.com> wrote: >> > Hi, >> > >> > PFA patch to add reset view/layout. >> > Please review. >> > >> > RM#1248 >> >> This needs to go on a different menu (File?), otherwise it won't be >> accessible when running in desktop mode. >> >> > - Additionally, attaching patch to fix validation issue. which was >> > causing >> > statistics tab to break if no node is selected on browser tree and user >> > clicks on statistics tab. >> > - And also observed an issue with panels causing strange errors which is >> > already fixed by Surinder .(Patch Link) >> >> Both committed - thanks! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company