Thread: PATCH: To fix the issue in type node (pgAdmin4)

PATCH: To fix the issue in type node (pgAdmin4)

From
Murtuza Zabuawala
Date:
Hi,

PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
(RM#1273)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: PATCH: To fix the issue in type node (pgAdmin4)

From
Ashesh Vashi
Date:

On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
(RM#1273)

The patch contains multiple fixes in the Type node.
Can you please explain, what these changes are for?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: PATCH: To fix the issue in type node (pgAdmin4)

From
Murtuza Zabuawala
Date:
Hi Ashesh,

I have fixed the issue and also corrected some validations as well in privileges.js where we were using object before validation it.

Thanks,
Murtuza.
 
On 02-Jun-2016, at 3:40 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
(RM#1273)

The patch contains multiple fixes in the Type node.
Can you please explain, what these changes are for?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers



Re: PATCH: To fix the issue in type node (pgAdmin4)

From
Ashesh Vashi
Date:
On Thu, Jun 2, 2016 at 3:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,

I have fixed the issue and also corrected some validations as well in privileges.js where we were using object before validation it.
Can you please give some details about those validations?

What was the issue, and how did you fix it?
 

Thanks,
Murtuza.
 
On 02-Jun-2016, at 3:40 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
(RM#1273)

The patch contains multiple fixes in the Type node.
Can you please explain, what these changes are for?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




Re: PATCH: To fix the issue in type node (pgAdmin4)

From
Murtuza Zabuawala
Date:
Hi,

We had condition where we were validating some model objects only if it’s in sessAttrs, which I have removed it now.
Issue: we were not getting error for required fields.


Regards,
Murtuza

On 02-Jun-2016, at 3:55 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Jun 2, 2016 at 3:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,

I have fixed the issue and also corrected some validations as well in privileges.js where we were using object before validation it.
Can you please give some details about those validations?

What was the issue, and how did you fix it?
 

Thanks,
Murtuza.
 
On 02-Jun-2016, at 3:40 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
(RM#1273)

The patch contains multiple fixes in the Type node.
Can you please explain, what these changes are for?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers





Re: PATCH: To fix the issue in type node (pgAdmin4)

From
Ashesh Vashi
Date:
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Thu, Jun 2, 2016 at 4:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

We had condition where we were validating some model objects only if it’s in sessAttrs, which I have removed it now.
Issue: we were not getting error for required fields.


Regards,
Murtuza

On 02-Jun-2016, at 3:55 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Jun 2, 2016 at 3:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,

I have fixed the issue and also corrected some validations as well in privileges.js where we were using object before validation it.
Can you please give some details about those validations?

What was the issue, and how did you fix it?
 

Thanks,
Murtuza.
 
On 02-Jun-2016, at 3:40 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
(RM#1273)

The patch contains multiple fixes in the Type node.
Can you please explain, what these changes are for?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers