Thread: Control for selecting multiple columns [pgadmin4]
Hi,
PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}Attachment
Hi,
Do you have a test dialogue or similar in which I can test this code? Ideally an addition to the test module would be good.
Thanks.
On Tue, Mar 8, 2016 at 7:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
Currently there is no test dialogue to test this control.
Also Ashesh has suggested some changes. Once I complete those changes; I'll resubmit the patch along with test dialogue to test it.
On Tue, Mar 8, 2016 at 4:16 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi,Do you have a test dialogue or similar in which I can test this code? Ideally an addition to the test module would be good.Thanks.On Tue, Mar 8, 2016 at 7:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi,
PFA generalized updated patch for backform multiSelectControl. On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Attachment
It seems to be missing the test dialogue?
On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
I have used same control in primary key constraint for selecting multiple columns. So to test this control please extract attached table.zip file under schema node. This zip contains table, column and constraint node with primary key support (as constraint node has dependency on table and column node). Also you will need to apply multiselect control patch separately as this zip does not contain the same.Thank you,
Harshal
On Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage@pgadmin.org> wrote:
It seems to be missing the test dialogue?On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi
I tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc.
On Thu, Mar 17, 2016 at 6:04 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Dave,I have used same control in primary key constraint for selecting multiple columns. So to test this control please extract attached table.zip file under schema node. This zip contains table, column and constraint node with primary key support (as constraint node has dependency on table and column node). Also you will need to apply multiselect control patch separately as this zip does not contain the same.Thank you,HarshalOn Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage@pgadmin.org> wrote:It seems to be missing the test dialogue?On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi Dave,
This seems to be some dependency issue. Can you please send me a screenshot of debugger console with js error stack.
Regards,
Harshal
On Thu, Mar 17, 2016 at 10:33 PM, Dave Page <dpage@pgadmin.org> wrote:
HiI tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc.On Thu, Mar 17, 2016 at 6:04 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,I have used same control in primary key constraint for selecting multiple columns. So to test this control please extract attached table.zip file under schema node. This zip contains table, column and constraint node with primary key support (as constraint node has dependency on table and column node). Also you will need to apply multiselect control patch separately as this zip does not contain the same.Thank you,HarshalOn Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage@pgadmin.org> wrote:It seems to be missing the test dialogue?On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
On Fri, Mar 18, 2016 at 6:32 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Dave,This seems to be some dependency issue. Can you please send me a screenshot of debugger console with js error stack.Regards,HarshalOn Thu, Mar 17, 2016 at 10:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiI tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc.On Thu, Mar 17, 2016 at 6:04 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,I have used same control in primary key constraint for selecting multiple columns. So to test this control please extract attached table.zip file under schema node. This zip contains table, column and constraint node with primary key support (as constraint node has dependency on table and column node). Also you will need to apply multiselect control patch separately as this zip does not contain the same.Thank you,HarshalOn Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage@pgadmin.org> wrote:It seems to be missing the test dialogue?On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Slightly expanded...
On Fri, Mar 18, 2016 at 10:29 AM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Mar 18, 2016 at 6:32 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,This seems to be some dependency issue. Can you please send me a screenshot of debugger console with js error stack.Regards,HarshalOn Thu, Mar 17, 2016 at 10:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiI tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc.On Thu, Mar 17, 2016 at 6:04 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,I have used same control in primary key constraint for selecting multiple columns. So to test this control please extract attached table.zip file under schema node. This zip contains table, column and constraint node with primary key support (as constraint node has dependency on table and column node). Also you will need to apply multiselect control patch separately as this zip does not contain the same.Thank you,HarshalOn Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage@pgadmin.org> wrote:It seems to be missing the test dialogue?On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi Dave,
The error is at line 84 in primary_key.js (from screenshot).
In primary_key.js it requires MultiSelectAjaxControl. I guess patch of MultiSelectControl was not applied correctly.
Can you please try again.
When testing it check if (in browser script tab) MultiSelectControl is there in node.ui.js at line no 562 (approx).
Regards,
Harshal
On Fri, Mar 18, 2016 at 4:00 PM, Dave Page <dpage@pgadmin.org> wrote:
Slightly expanded...On Fri, Mar 18, 2016 at 10:29 AM, Dave Page <dpage@pgadmin.org> wrote:On Fri, Mar 18, 2016 at 6:32 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,This seems to be some dependency issue. Can you please send me a screenshot of debugger console with js error stack.Regards,HarshalOn Thu, Mar 17, 2016 at 10:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiI tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc.On Thu, Mar 17, 2016 at 6:04 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,I have used same control in primary key constraint for selecting multiple columns. So to test this control please extract attached table.zip file under schema node. This zip contains table, column and constraint node with primary key support (as constraint node has dependency on table and column node). Also you will need to apply multiselect control patch separately as this zip does not contain the same.Thank you,HarshalOn Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage@pgadmin.org> wrote:It seems to be missing the test dialogue?On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA generalized updated patch for backform multiSelectControl.On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Note: When using this control model should have column attribute. And node property should be column.Usage:Hi,PFA backform control for selecting multiple columns.(This control depends on column node.){
id: 'columns', label: '{{ _('Columns') }}',
type: 'collection', group: '{{ _('Definition') }}', editable:true,
canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
keys: ['column'],
defaults: {
column: undefined
}
})
}
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Dave,The error is at line 84 in primary_key.js (from screenshot).In primary_key.js it requires MultiSelectAjaxControl. I guess patch of MultiSelectControl was not applied correctly.Can you please try again.When testing it check if (in browser script tab) MultiSelectControl is there in node.ui.js at line no 562 (approx).
OK, I got it in the end. Took a lot of repeated cache clear outs though :-(
So... I see two issues:
1) The control has a black border when it has focus, unlike other controls that have gray ones.
2) The sizing is different from other controls, whether in large screen or small screen modes. Please see the attached screenshots. The control should be positioned and sized just like a text control (with the exception that it expands to multiple rows if needed, as it does).
Thanks.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi,
Here is updated patchOn Fri, Mar 18, 2016 at 9:37 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,The error is at line 84 in primary_key.js (from screenshot).In primary_key.js it requires MultiSelectAjaxControl. I guess patch of MultiSelectControl was not applied correctly.Can you please try again.When testing it check if (in browser script tab) MultiSelectControl is there in node.ui.js at line no 562 (approx).OK, I got it in the end. Took a lot of repeated cache clear outs though :-(So... I see two issues:1) The control has a black border when it has focus, unlike other controls that have gray ones.
Fixed.
2) The sizing is different from other controls, whether in large screen or small screen modes. Please see the attached screenshots. The control should be positioned and sized just like a text control (with the exception that it expands to multiple rows if needed, as it does).
Fixed.
Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi,
PFA patch for MultiselectControl.On Mon, Mar 21, 2016 at 11:35 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Here is updated patchOn Fri, Mar 18, 2016 at 9:37 PM, Dave Page <dpage@pgadmin.org> wrote:On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,The error is at line 84 in primary_key.js (from screenshot).In primary_key.js it requires MultiSelectAjaxControl. I guess patch of MultiSelectControl was not applied correctly.Can you please try again.When testing it check if (in browser script tab) MultiSelectControl is there in node.ui.js at line no 562 (approx).OK, I got it in the end. Took a lot of repeated cache clear outs though :-(So... I see two issues:1) The control has a black border when it has focus, unlike other controls that have gray ones.Fixed.
2) The sizing is different from other controls, whether in large screen or small screen modes. Please see the attached screenshots. The control should be positioned and sized just like a text control (with the exception that it expands to multiple rows if needed, as it does).Fixed.
Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks - applied.
On Tue, Mar 22, 2016 at 10:10 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Issue: Fixed issue when parsing undefined data as json.Hi,PFA patch for MultiselectControl.On Mon, Mar 21, 2016 at 11:35 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Here is updated patchOn Fri, Mar 18, 2016 at 9:37 PM, Dave Page <dpage@pgadmin.org> wrote:On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi Dave,The error is at line 84 in primary_key.js (from screenshot).In primary_key.js it requires MultiSelectAjaxControl. I guess patch of MultiSelectControl was not applied correctly.Can you please try again.When testing it check if (in browser script tab) MultiSelectControl is there in node.ui.js at line no 562 (approx).OK, I got it in the end. Took a lot of repeated cache clear outs though :-(So... I see two issues:1) The control has a black border when it has focus, unlike other controls that have gray ones.Fixed.
2) The sizing is different from other controls, whether in large screen or small screen modes. Please see the attached screenshots. The control should be positioned and sized just like a text control (with the exception that it expands to multiple rows if needed, as it does).Fixed.
Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company