Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][Patch]: Added some backgrid extensions

[pgAdmin4][Patch]: Added some backgrid extensions

From
Akshay Joshi
Date:
Hi All 

I have added some backgrid extensions like select-all, paginator and filter. This extensions will be required for other modules like Grant Wizard, Data Grid. Attached is the patch file, please review it and let me know the comments if any. If it looks good then please commit the code.

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgAdmin4][Patch]: Added some backgrid extensions

From
Dave Page
Date:


On Thu, Feb 25, 2016 at 3:14 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have added some backgrid extensions like select-all, paginator and filter. This extensions will be required for other modules like Grant Wizard, Data Grid. Attached is the patch file, please review it and let me know the comments if any. If it looks good then please commit the code.

Looks fine, except you forgot to update libraries.txt.

Please fix and I'll commit.

Thanks. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Added some backgrid extensions

From
Akshay Joshi
Date:


On Fri, Feb 26, 2016 at 3:49 PM, Dave Page <dpage@pgadmin.org> wrote:


On Thu, Feb 25, 2016 at 3:14 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have added some backgrid extensions like select-all, paginator and filter. This extensions will be required for other modules like Grant Wizard, Data Grid. Attached is the patch file, please review it and let me know the comments if any. If it looks good then please commit the code.

Looks fine, except you forgot to update libraries.txt.

Please fix and I'll commit.

   Fixed. Attached is the modified patch. 

Thanks. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgAdmin4][Patch]: Added some backgrid extensions

From
Dave Page
Date:
Thanks - applied.

On Fri, Feb 26, 2016 at 11:00 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Fri, Feb 26, 2016 at 3:49 PM, Dave Page <dpage@pgadmin.org> wrote:


On Thu, Feb 25, 2016 at 3:14 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have added some backgrid extensions like select-all, paginator and filter. This extensions will be required for other modules like Grant Wizard, Data Grid. Attached is the patch file, please review it and let me know the comments if any. If it looks good then please commit the code.

Looks fine, except you forgot to update libraries.txt.

Please fix and I'll commit.

   Fixed. Attached is the modified patch. 

Thanks. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company